Improve contribution list filter accessibility #7200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3fb1fef to
97442eb
Compare
Member
|
Looks quite broken in Firefox... (why are these dropdowns so huge?) |
- Ensure keyboard and screen reader accessibility of the contrib filters - Apply design system - Extract shared behaviors into the new behaviors module TODO: Reuse the extracted behaviors in existing controls
97442eb to
cc0014d
Compare
Collaborator
Author
|
Here's what it looks like for me on Firefox: I fixed the button padding to make them a bit smaller. I thought we'd already used them before somewhere but I guess none of those PRs were ever merged. |
Member
|
Yes, your screenshot matches pretty much what I see at the moment. To me that looks broken, dropdown widgets are pretty much nowhere that big... |
Collaborator
Author
But this is not a dropdown widget. This is technically a button that also has a dropdown. |
Collaborator
Author
|
In fact, it's two buttons with a dropdown. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Reuse the extracted behaviors in existing controls
Before
After