-
Couldn't load subscription status.
- Fork 410
Fix(): wanderer cover positions are now saved when defined #2200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
knro
merged 2 commits into
indilib:master
from
grm:fix_wanderer_cover_save_open_close_value
Mar 16, 2025
Merged
Fix(): wanderer cover positions are now saved when defined #2200
knro
merged 2 commits into
indilib:master
from
grm:fix_wanderer_cover_save_open_close_value
Mar 16, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knro
reviewed
Mar 15, 2025
knro
reviewed
Mar 15, 2025
knro
added a commit
that referenced
this pull request
Mar 17, 2025
* Initial work to migrate Focuser driver to new properties * Migrate aaf2 * Migrate Celestron * Migrate Active Focuser * Migrate Astromech focuser * Migrate deepskydad_af1 * Migrate deepskydad_af2 * Migrate deepskydad_af3 * Migrate dmfc * Migrate dreamfocuser * Migrate planewave_efa * Update esatto.cpp * Migrate esattoarco * Migrate fcusb * Migrate hitecastrodcfocuser * Migrate lacerta_mfoc_fmc * Migrate lacerta_mfoc * Fix all problems * Use isEmpty() instead of nullptr * use SetFocuserMaxPosition * Fix using SetFocuserMaxPosition * use INDI_Enabled/Disabled * Fix warnings * lx200zeq25 telescope driver: RA and DEC formats were incorrectly detected. Implemented correct format. Gotos are now accurate (#2178) * Fix(): Test fixing pyindi-client build (#2181) * Test fixing pyindi-client build * Update github workflow to use a venv * Update github workflow to add dependencies * Adding new packages * testing new approach * adapt build process * adapt build process * New approach * Update agin build * Update agin build * damn GSC :) * Feat(): alpaca dome and alpaca weather safety (#2177) * Adding driver for alpaca dome * Config is now saved * Add Alpaca weather safety monitor * License * Change manufacturer to Alpaca * Use enums for keywords. Fixes #2183 * fix unpark lx200gps.cpp (#2184) unpark was not updating values and following move failed * Fix formatting * Move io drivers to their own directory. Add simulator io. Fix universal ROR when input or output devices are initialized late. * Add support for CheapoDC v2.2.0. Allows for up to 4 addtional power outputs added to the core 2 dew controller outputs. (#2191) * Add driver for cloudwatcher solo from lunaticoastro (#2171) * Add driver for solo * Added driver.xml and changed name to aagsolo * Follow convention of driver names * Rewrite initProperties following knro's advise * Improve readability of the indiserver (#2176) * split the indiserver.cpp into multiple files * using an enum class instead of an enum * adding unistd.h so mac build passes * Update indiserver/ClInfo.cpp * ran artistic style per the repo instructions * attempting to get actions to run * remove debian-buster as it was EOL'd 6/2024 * Remove websocket support as it is no longer maintained. * Fix(): wanderer rotator - the backlash value was incorrectly read during handshake (#2195) * Fix build warning - Removing clang-extensions for variable length arrays (#2192) * addressing warning regarding clang extensions for dynamic array, replaced with std::vector * update the sizeof calc * Add dust cover simulator * FIX(): Alpaca weather safety now correctly manager danger zone (#2199) * Fix(): Wanderer cover v3 is now working with the scheduler (#2193) * Fix(): Wanderer cover should now work with scheduler and sequence job * Revert wanderer v4 driver * Add missing timeout calls. Thank to Artyom Beilis for finding the issue. * Mark more properties as standard (pending focuser) to improve documentation * Add missing INDI_STANDARD_PROPERTY tags * Fix wanderer cover timer failing when other command running (#2201) * Fix(): WandererCover v4: Errors should not appear anymore when the timerhit function try to update data and a move is in progress. Also progress should now be displayed in the UI. * waitForDone * Adapt logs and remove wrong logs * Adding firmware version * Default values are the saved ones * Fix(): wanderer cover positions are now saved when defined (#2200) * Fix(): wanderer cover positions are now saved when defined * Saving saves only the changed parameter * Update to use modern INDI properties and logging * Fix issue with receiver * Fix error --------- Co-authored-by: Salman Naheed <[email protected]> Co-authored-by: Nelson Sousa <[email protected]> Co-authored-by: Jérémie Klein <[email protected]> Co-authored-by: jordisese <[email protected]> Co-authored-by: hcomet <[email protected]> Co-authored-by: Peter Englmaier <[email protected]> Co-authored-by: Jordan Maples <[email protected]>
knro
added a commit
to knro/indi
that referenced
this pull request
Mar 23, 2025
* Initial work to migrate Focuser driver to new properties * Migrate aaf2 * Migrate Celestron * Migrate Active Focuser * Migrate Astromech focuser * Migrate deepskydad_af1 * Migrate deepskydad_af2 * Migrate deepskydad_af3 * Migrate dmfc * Migrate dreamfocuser * Migrate planewave_efa * Update esatto.cpp * Migrate esattoarco * Migrate fcusb * Migrate hitecastrodcfocuser * Migrate lacerta_mfoc_fmc * Migrate lacerta_mfoc * Fix all problems * Use isEmpty() instead of nullptr * use SetFocuserMaxPosition * Fix using SetFocuserMaxPosition * use INDI_Enabled/Disabled * Fix warnings * lx200zeq25 telescope driver: RA and DEC formats were incorrectly detected. Implemented correct format. Gotos are now accurate (indilib#2178) * Fix(): Test fixing pyindi-client build (indilib#2181) * Test fixing pyindi-client build * Update github workflow to use a venv * Update github workflow to add dependencies * Adding new packages * testing new approach * adapt build process * adapt build process * New approach * Update agin build * Update agin build * damn GSC :) * Feat(): alpaca dome and alpaca weather safety (indilib#2177) * Adding driver for alpaca dome * Config is now saved * Add Alpaca weather safety monitor * License * Change manufacturer to Alpaca * Use enums for keywords. Fixes indilib#2183 * fix unpark lx200gps.cpp (indilib#2184) unpark was not updating values and following move failed * Fix formatting * Move io drivers to their own directory. Add simulator io. Fix universal ROR when input or output devices are initialized late. * Add support for CheapoDC v2.2.0. Allows for up to 4 addtional power outputs added to the core 2 dew controller outputs. (indilib#2191) * Add driver for cloudwatcher solo from lunaticoastro (indilib#2171) * Add driver for solo * Added driver.xml and changed name to aagsolo * Follow convention of driver names * Rewrite initProperties following knro's advise * Improve readability of the indiserver (indilib#2176) * split the indiserver.cpp into multiple files * using an enum class instead of an enum * adding unistd.h so mac build passes * Update indiserver/ClInfo.cpp * ran artistic style per the repo instructions * attempting to get actions to run * remove debian-buster as it was EOL'd 6/2024 * Remove websocket support as it is no longer maintained. * Fix(): wanderer rotator - the backlash value was incorrectly read during handshake (indilib#2195) * Fix build warning - Removing clang-extensions for variable length arrays (indilib#2192) * addressing warning regarding clang extensions for dynamic array, replaced with std::vector * update the sizeof calc * Add dust cover simulator * FIX(): Alpaca weather safety now correctly manager danger zone (indilib#2199) * Fix(): Wanderer cover v3 is now working with the scheduler (indilib#2193) * Fix(): Wanderer cover should now work with scheduler and sequence job * Revert wanderer v4 driver * Add missing timeout calls. Thank to Artyom Beilis for finding the issue. * Mark more properties as standard (pending focuser) to improve documentation * Add missing INDI_STANDARD_PROPERTY tags * Fix wanderer cover timer failing when other command running (indilib#2201) * Fix(): WandererCover v4: Errors should not appear anymore when the timerhit function try to update data and a move is in progress. Also progress should now be displayed in the UI. * waitForDone * Adapt logs and remove wrong logs * Adding firmware version * Default values are the saved ones * Fix(): wanderer cover positions are now saved when defined (indilib#2200) * Fix(): wanderer cover positions are now saved when defined * Saving saves only the changed parameter * Update to use modern INDI properties and logging * Fix issue with receiver * Fix error --------- Co-authored-by: Salman Naheed <[email protected]> Co-authored-by: Nelson Sousa <[email protected]> Co-authored-by: Jérémie Klein <[email protected]> Co-authored-by: jordisese <[email protected]> Co-authored-by: hcomet <[email protected]> Co-authored-by: Peter Englmaier <[email protected]> Co-authored-by: Jordan Maples <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.