Add NUT UPS Safety device support to drivers.xml #2276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knro
reviewed
Sep 6, 2025
drivers.xml
Outdated
| <version>1.0</version> | ||
| </device> | ||
| <device label="NUT UPS Safety" manufacturer="NUT UPS Safety"> | ||
| <driver name="UPS Safety">indi_ups_safety</driver> |
There was a problem hiding this comment.
In the driver, getDefaultName() return UPS so this should be:
<driver name="UPS">indi_ups_safety</driver>
There was a problem hiding this comment.
Ok, I was not aware that it should match.
I will update it
knro
pushed a commit
to knro/indi
that referenced
this pull request
Sep 6, 2025
* Add NUT UPS Safety device support to drivers.xml * Rename UPS driver
knro
added a commit
that referenced
this pull request
Sep 6, 2025
* Initial work for IMU support in INDI * Add missing files * register connections * Use single property for i2c connection and remove drivers from here due to external dependencies * Fix update error * No need to ask flat light should be on first since we are essentially turning it on * When no filters are detected, save LightIntensity in configuraiton file * If light box is not on then simply accept the light intensity value as is so it can be saved * Do not read intensity in timer so that it does not overwrite our INDI settings which can be set to a particular value without requiring the light to be ON. It is only applied with the light is toggled on. * Get intensity of startup * Turn off light on Disconnect * Add updateProperty convenience function * More fixes for INDI Alpaca camera driver * Do not use magic numbers * Use threshold to reduce traffic to client * Split the units * Use Coordinates tab * More cleanups and add SmartEye camera * Add convenience function to get first ISS_ON in ISState array * Fix camelot rotator issues: 1. Remove extra new-line in sendCommand. 2. Fix formatting for power properties. 3. Save configuration for power properties. * Add NUT UPS Safety device support to drivers.xml (#2276) * Add NUT UPS Safety device support to drivers.xml * Rename UPS driver * More fixes * Add Geographic location and magnetic declination * Initial Quaternion to Euler calculations for Az-Alt system * Fix coordinate system selection * Fix Mount Offset property * Add more logging and recalculate after changing offsets or declination * Adjust az * Core interface functions shouldn't be virtual * Fix MacOS error --------- Co-authored-by: Jérémie Klein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.