Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Work around numpy2's changed repr for scalars #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2024
Merged

Work around numpy2's changed repr for scalars #837

merged 1 commit into from
Apr 16, 2024

Conversation

inducer
Copy link
Owner

@inducer inducer commented Apr 15, 2024

Closes gh-835

cc @connorjward

@inducer inducer changed the title Work around numpy2's changed repr for scalars Work around numpy2's changed repr for scalars Apr 15, 2024
@inducer inducer mentioned this pull request Apr 15, 2024
Closed
@inducer inducer enabled auto-merge (rebase) April 15, 2024 18:58
@inducer inducer disabled auto-merge April 15, 2024 19:21
@inducer
Copy link
Owner Author

inducer commented Apr 15, 2024 •
edited
Loading

@connorjward It looks like the Firedrake downstream test fails with something that's inscrutable to me. Do you have a sense what could be wrong here?

@connorjward
Copy link
Contributor

@connorjward It looks like the Firedrake downstream test fails with something that's inscrutable to me. Do you have a sense what could be wrong here?

If you scroll down far enough you get to the real error:

File "/home/firedrake/firedrake/lib/python3.10/site-packages/pymbolic/mapper/__init__.py", line 155, in __call__
    return self.map_foreign(expr, *args, **kwargs)
  File "/home/firedrake/firedrake/lib/python3.10/site-packages/pymbolic/mapper/__init__.py", line 215, in map_foreign
    return self.map_constant(expr, *args, **kwargs)
  File "/home/firedrake/loopy/loopy/target/c/codegen/expression.py", line 637, in map_constant
    if isinstance(expr.integer):
AttributeError: 'numpy.int32' object has no attribute 'integer'. Did you mean: 'is_integer'?

Our callback infrastructure with PETSc sometimes hides the sources of crashes.

@inducer
Copy link
Owner Author

inducer commented Apr 16, 2024

Oh dang. Sorry I missed that, and thanks for pointing it out!

@inducer inducer enabled auto-merge (rebase) April 16, 2024 13:30
@inducer inducer merged commit 38deb28 into main Apr 16, 2024
@inducer inducer deleted the npy2-compat branch April 16, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Loopy does not generate valid C code with numpy 2.0 (release candidate)

2 participants

@inducer @connorjward