Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix _InameDuplicator.within #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
inducer merged 3 commits into from
Jul 30, 2024
Merged

Fix _InameDuplicator.within #860

inducer merged 3 commits into from
Jul 30, 2024

Conversation

@kaushikcfd
Copy link
Collaborator

@kaushikcfd kaushikcfd commented Jul 29, 2024

  • Changed to update the inames of the instructions that do not access an inames, yet, are nested within the iname to be duplicated.
  • Closes Bug in lp.duplicate_inames #859

@inducer
Copy link
Owner

inducer commented Jul 29, 2024 •
edited
Loading

Thanks! Could you look at the test failures? They seem related.

@kaushikcfd kaushikcfd force-pushed the fix-gh-859 branch 2 times, most recently from 4bb98c5 to 58a2072 Compare July 29, 2024 16:37
@kaushikcfd
Copy link
Collaborator Author

kaushikcfd commented Jul 29, 2024

Thanks! Could you look at the test failures? They seem related.

Seemed to be a bug in kernel.creation. Looks like we were calling duplicate_inames without adding the relevant inames within the insns.

Also, TIL about the "dup=i" syntax in make_kernel. :)

@kaushikcfd kaushikcfd requested a review from inducer July 29, 2024 16:42
inducer
inducer reviewed Jul 29, 2024
View reviewed changes
Copy link
Owner

@inducer inducer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM except for one missing bit of comment.

@kaushikcfd
[kernel.creation] duplicate inames only after adding all relevant inames
37036ff
@kaushikcfd
Fix _InameDuplicator.within
903d625 
* Changed to update the inames of the instructions that do not access an
  inames, yet, are nested within the iname to be duplicated.
@kaushikcfd
Test iname duplication for cases with only loop-nest based iname-depe…
050d355 
…ndence
@inducer inducer enabled auto-merge (rebase) July 30, 2024 15:49
@inducer
Copy link
Owner

inducer commented Jul 30, 2024

Thx!

@inducer inducer merged commit f01a86b into main Jul 30, 2024
@inducer inducer deleted the fix-gh-859 branch July 30, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inducer inducer inducer left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug in lp.duplicate_inames

3 participants

@kaushikcfd @inducer