Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kaushikcfd
Copy link
Collaborator

Closes #865.

Given that happens_after is a sufficiently big change, I suggest we release a new version.

@kaushikcfd
Copy link
Collaborator Author

Looks like this patch broke our persistent caching mechanism. I am also getting CollisionWarnings locally. Looking into it.

@inducer
Copy link
Owner

inducer commented Sep 8, 2024

cc @a-alveyblanc

@kaushikcfd kaushikcfd force-pushed the fix_happens_after_type branch from 1d7a732 to 78e4424 Compare September 8, 2024 19:44
@inducer
Copy link
Owner

inducer commented Sep 8, 2024

The test failures in tutorial.rst should subside as soon as isl 0.27 enters conda-forge: conda-forge/isl-feedstock#32.

@inducer
Copy link
Owner

inducer commented Sep 8, 2024

Unless we expect the dictionaries to extensively rewritten, immutabledict is (1) far cheaper and (2) predictably ordered.

@matthiasdiener did some benchmarks at some point.

@kaushikcfd
Copy link
Collaborator Author

should subside as soon as isl 0.27 enters conda-forge

Thanks! :D

@kaushikcfd
Copy link
Collaborator Author

Unless we expect the dictionaries to extensively rewritten, immutabledict is (1) far cheaper and (2) predictably ordered.

Sg! I'll switch over to it.

@inducer
Copy link
Owner

inducer commented Sep 8, 2024

The test failures in tutorial.rst should subside as soon as isl 0.27 enters conda-forge: conda-forge/isl-feedstock#32.

I lied. This needs an islpy rebuild, too: conda-forge/islpy-feedstock#55

@kaushikcfd kaushikcfd force-pushed the fix_happens_after_type branch from 78e4424 to b9c5eae Compare September 8, 2024 20:51
@inducer inducer force-pushed the fix_happens_after_type branch from 1bd25d0 to 72d6cc9 Compare September 9, 2024 19:35
@inducer inducer enabled auto-merge (squash) September 9, 2024 19:35
@inducer
Copy link
Owner

inducer commented Sep 9, 2024

Thanks!

@inducer inducer merged commit 070df9f into main Sep 9, 2024
@inducer inducer deleted the fix_happens_after_type branch September 9, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HEAD is breaking back-compat wrt loopy==2024.1

3 participants