Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix the conflict issues within the transaction #2606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 15, 2025
Merged

Fix the conflict issues within the transaction #2606

merged 2 commits into from
May 15, 2025

Conversation

@euvre
Copy link
Contributor

@euvre euvre commented May 15, 2025

What problem does this PR solve?

  1. For each relevant txn, we calculate LatestID in incrLatestID using the kv_instance obtained during the txn's begin phase. This approach solved some known bugs. Howerver, it introduces some performance issue, such as the inability to create db, table, and index concurrently. A possible solution is to maintain an additional field for each Name to represent the entity name currently being created. When the names differ, concurrent creation will be allowed.
  2. Other fixed have been made to accommodate the changes mentioned above.
  3. Conflict detection ha been added for dropDB and dropDB.
  4. The write-to-cache operation has been moved into commitBottom to avoid conflict.

Type of change

  • Bug Fix (non-breaking change which fixes an issue)

@euvre euvre changed the title Txn fix Fix the conflict issues within the transaction May 15, 2025
@euvre euvre added ci PR can be test and removed ci PR can be test labels May 15, 2025
@JinHai-CN JinHai-CN merged commit 4e8f06c into infiniflow:main May 15, 2025
8 of 10 checks passed
@euvre euvre deleted the txn_fix branch May 16, 2025 06:47
@euvre euvre mentioned this pull request May 16, 2025
Merged
1 task
JinHai-CN pushed a commit that referenced this pull request May 17, 2025
@euvre
Fix txn create index (#2611)
5b84b46 
### What problem does this PR solve?
 
As a follow-up change to #2606 .

### Type of change

- [x] Performance Improvement

Signed-off-by: noob <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ci PR can be test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@euvre @JinHai-CN