Remove react-native-cli and copy over files ourselves #1697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markrickert
reviewed
Jun 3, 2021
| await copyBoilerplate(toolbox, { | ||
| boilerplatePath, | ||
| projectName, | ||
| excluded: ["node_modules", "yarn.lock", /.?\.expo\..?/], |
There was a problem hiding this comment.
nice! Excluding all expo files with a regex :D
There was a problem hiding this comment.
Took me a bit to remember if the wildcard should be ?. or .?. haha
markrickert
approved these changes
Jun 3, 2021
|
Pushing up a fix for the test failure. |
infinitered-circleci
pushed a commit
that referenced
this pull request
Jun 3, 2021
## [7.0.1](v7.0.0...v7.0.1) (2021-06-03) ### Bug Fixes * **cli:** Remove react-native-cli and copy over files ourselves ([#1697](#1697) by [@jamonholmgren](https://github.com/jamonholmgren)) ([a318803](a318803))
|
🎉 This PR is included in version 7.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was spurred on by some (apparently local?) problems I was having with the react-native CLI. However, I think it's worth a look even if react-native-cli works fine.
This PR removes our dependency on
@react-native-community/cliakareact-native-cliand instead undertakes copying over the boilerplate files ourselves (when not using Expo).Since the boilerplate is essentially already a runnable project, this is a pretty straightforward copy operation. We still do some cleanup by removing any stray Expo files that make it in and also run
npx react-native-renameon it -- since your app is probably not namedHelloWorld.It seems that most of the time spinning up a new Ignite app is still when it's
yarn installing. We probably need to spend time stripping our dependencies down a bit more.This shouldn't make any breaking changes to the boilerplate. This would also supplant #1696 if we merge it.