Remove ramda-omit leftovers from NAME.ts.ejs #1708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As 'ramda' package has been complete removed, as has the ```import {omit} from 'ramda'``` on top of file, I believe this comment section should be removed as well.
jamonholmgren
approved these changes
Jun 24, 2021
There was a problem hiding this comment.
Thanks @JeroenGoddijn! I see it's your first time contributing to Ignite; I really appreciate it and hope you do more!
infinitered-circleci
pushed a commit
that referenced
this pull request
Jun 24, 2021
## [7.0.4](v7.0.3...v7.0.4) (2021-06-24) ### Bug Fixes * **boilerplate:** Update NAME.ts.ejs to remove unnecessary ramda comments ([#1708](#1708) by @JeroenGoddijn) ([42f825c](42f825c))
|
🎉 This PR is included in version 7.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Yeah...created PR to remove types package from package.json as well 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As 'ramda' package has been complete removed, as has the
import {omit} from 'ramda'on top of file, I believe this comment section should be removed as well.Please verify the following:
yarn ci:testjest tests pass with new tests, if relevantREADME.mdhas been updated with your changes, if relevantDescribe your PR