fix(metro): Add support for cjs extension in metro.config.js #2689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankcalise
approved these changes
May 28, 2024
There was a problem hiding this comment.
@jamonholmgren I think experimentalImportSupport: false is just the default value. It wasn't specifically false for any reason other than we grabbed both values when setting inlineRequires to true, more just about being explicit.
We can document the comment that way or just remove the line altogether
I plan on merging this with Expo 51 and a few others, so once you remove the line or document it, feel free to merge it skipping CI so we can bundle them all together (or I can handle it, just LMK)
infinitered-circleci
pushed a commit
that referenced
this pull request
May 29, 2024
# [9.7.0](v9.6.3...v9.7.0) (2024-05-29) ### Bug Fixes * **boilerplate:** fix deep link not working with navigation persist ([#2679](#2679) by [@vanenshi](https://github.com/vanenshi)) ([a0cd8ce](a0cd8ce)) * **cli:** better support for yarn 2+ ([#2684](#2684) by [@frankcalise](https://github.com/frankcalise) and [@morganick](https://github.com/morganick)) ([e38a02c](e38a02c)) * **metro:** Add support for cjs extension in metro.config.js ([#2689](#2689) by [@jamonholmgren](https://github.com/jamonholmgren)) ([7544fac](7544fac)) ### Features * **boilerplate:** upgrade to Expo SDK 51 ([#2683](#2683) by [@frankcalise](https://github.com/frankcalise)) ([e0f3aa8](e0f3aa8)), closes [#2692](#2692)
|
🎉 This PR is included in version 9.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweaks the metro config to add support for .cjs so we support Firebase.js out of the box with no other config changes.
Also adds some comments for inline requires.