Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(boilerplate): bump RN 0.74.2 #2695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2024
Merged

fix(boilerplate): bump RN 0.74.2 #2695

merged 2 commits into from
Jun 10, 2024

Conversation

@frankcalise
Copy link
Contributor

@frankcalise frankcalise commented Jun 8, 2024 •
edited
Loading

Please verify the following:

  • yarn test jest tests pass with new tests, if relevant
  • yarn lint eslint checks pass with new code, if relevant
  • yarn format:check prettier checks pass with new code, if relevant
  • README.md (or relevant documentation) has been updated with your changes

Describe your PR

[Error: Module "1" is missing from the asset registry]

@frankcalise frankcalise requested a review from mazenchami June 8, 2024 18:33
@frankcalise frankcalise linked an issue Jun 8, 2024 that may be closed by this pull request
Getting Started - the app lands on a blank page #2694
Closed
@frankcalise frankcalise mentioned this pull request Jun 8, 2024
Closed
@AtlantisPleb
Copy link

AtlantisPleb commented Jun 9, 2024 •
edited
Loading

Seems there is still an underlying issue with the font loading.

This PR's fix gets past the white screen, but the error persists - and SpaceGrotesk never loads.

  if (!rehydrated || !isNavigationStateRestored || (!areFontsLoaded && !fontLoadError)) {
    return null
  } else {
    console.log(fontLoadError)
  }

...still gives:
[Error: Module "1" is missing from the asset registry]

and SpaceGrotesk is missing:

nospace

(on a fresh Ignite app with:)

      npx ignite-cli new PizzaApp \
        --bundle=com.demo.app \
        --git \
        --install-deps \
        --packager=yarn \
        --target-path=/Users/username/code/pizzaapp \
        --remove-demo=false \
        --workflow=expo \
        --no-timeout=false

@frankcalise frankcalise mentioned this pull request Jun 9, 2024
Closed
@frankcalise frankcalise changed the title fix(boilerplate): properly wait for fonts to load fix(boilerplate): bump RN 0.74.2 Jun 10, 2024
@frankcalise frankcalise merged commit df94f0d into master Jun 10, 2024
@frankcalise frankcalise deleted the @frankcalise/font-load-error branch June 10, 2024 04:45
infinitered-circleci pushed a commit that referenced this pull request Jun 10, 2024
@semantic-release-bot
chore(release): 9.7.1 [skip ci]
2ba623f 
## [9.7.1](v9.7.0...v9.7.1) (2024-06-10)

### Bug Fixes

* **boilerplate:** bump RN 0.74.2 ([#2695](#2695) by [@frankcalise](https://github.com/frankcalise)) ([df94f0d](df94f0d))
@infinitered-circleci
Copy link
Collaborator

🎉 This PR is included in version 9.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mazenchami mazenchami Awaiting requested review from mazenchami

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Getting Started - the app lands on a blank page

3 participants

@frankcalise @AtlantisPleb @infinitered-circleci