Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(inputs.procstat)!: Remove useless zero cpu_times #14224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 31, 2023
Merged

feat(inputs.procstat)!: Remove useless zero cpu_times #14224

merged 2 commits into from
Oct 31, 2023

Conversation

@srebhan
Copy link
Member

@srebhan srebhan commented Oct 31, 2023

resolves #2627

This PR removes the useless fields

  • cpu_time_guest
  • cpu_time_guest_nice
  • cpu_time_idle
  • cpu_time_irq
  • cpu_time_nice
  • cpu_time_soft_irq
  • cpu_time_steal

as those are never set by the underlying gopsutil library. Thus those fields are always zero. The PR keeps cpu_time_iowait which is zero for all platforms except Linux and adds a notice to the README about that fact.

@telegraf-tiger telegraf-tiger bot added area/procstat fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Oct 31, 2023
@srebhan srebhan changed the title fix(inputs.procstat): Remove useless zero cpu_times feat!(inputs.procstat): Remove useless zero cpu_times Oct 31, 2023
@srebhan srebhan changed the title feat!(inputs.procstat): Remove useless zero cpu_times feat(inputs.procstat)!: Remove useless zero cpu_times Oct 31, 2023
@srebhan srebhan added breaking change Improvement to Telegraf that requires changes to the plugin or agent; for minor/major releases feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin and removed fix pr to fix corresponding bug labels Oct 31, 2023
powersj
powersj approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 31, 2023
@srebhan srebhan self-assigned this Oct 31, 2023
@powersj powersj force-pushed the procstat_issue_2627 branch from 3f6e511 to 95ebf0c Compare October 31, 2023 20:35
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Oct 31, 2023

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@powersj powersj merged commit 76b3118 into influxdata:master Oct 31, 2023
@github-actions github-actions bot added this to the v1.29.0 milestone Oct 31, 2023
Hipska added a commit to Super-Visions/telegraf that referenced this pull request Nov 2, 2023
@Hipska
Merge remote-tracking branch 'upstream/master' into feat/processors/s…
f4fd7ce 
…nmp_lookup

* upstream/master:
  chore(linters): Fix findings found by testifylint: expected-actual (influxdata#14229)
  chore(deps): Bump github.com/nats-io/nkeys from 0.4.5 to 0.4.6 (influxdata#14225)
  feat(inputs.procstat)!: Remove useless zero cpu_times (influxdata#14224)
  feat(inputs.gnmi): Rework plugin (influxdata#14091)
  fix(outputs.timestream): Clip uint64 values (influxdata#14213)
  fix(inputs.cgroup): Escape backslashes (influxdata#14187)
  test(outputs.kafka): Use private network for testing (influxdata#14220)
  test(inputs.vault): Fix integration test by only testing for subset (influxdata#14222)
  fix(outputs.elasticsearch): Print error status value (influxdata#14115)
@Porkepix Porkepix mentioned this pull request Dec 11, 2023
Merged
@arenner-git arenner-git mentioned this pull request Dec 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@powersj powersj powersj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@srebhan srebhan

Labels

area/procstat breaking change Improvement to Telegraf that requires changes to the plugin or agent; for minor/major releases feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Milestone

v1.29.0

Development

Successfully merging this pull request may close these issues.

most procstat time fields useless

2 participants

@srebhan @powersj