Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(parsers.json_v2): Handle measurements with multiple objects correctly #16878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

fix(parsers.json_v2): Handle measurements with multiple objects correctly #16878

merged 1 commit into from
May 8, 2025

Conversation

@elv-gilles
Copy link
Contributor

@elv-gilles elv-gilles commented Apr 24, 2025

Summary

telegraf mixes all measurements when using json_v2 parser configured with multiple measurements,

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16877

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Apr 24, 2025
@srebhan srebhan changed the title fix(json_v2 parser): measurements overridden with multiple objects fix(json_v2 parser): Handle measurements with multiple objects correctly May 7, 2025
@srebhan srebhan changed the title fix(json_v2 parser): Handle measurements with multiple objects correctly fix(parsers.json_v2): Handle measurements with multiple objects correctly May 7, 2025
@telegraf-tiger telegraf-tiger bot added area/json json and json_v2 parser/serialiser related plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins labels May 7, 2025
srebhan
srebhan reviewed May 7, 2025
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant to approve...

srebhan
srebhan approved these changes May 7, 2025
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @elv-gilles!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 7, 2025
skartikey
skartikey approved these changes May 8, 2025
View reviewed changes
Copy link
Contributor

@skartikey skartikey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elv-gilles Thanks for the contribution!

@skartikey skartikey merged commit c31d402 into influxdata:master May 8, 2025
27 of 28 checks passed
@github-actions github-actions bot added this to the v1.35.0 milestone May 8, 2025
@elv-gilles elv-gilles deleted the jsonv2-parser-fix-multiple-objects branch May 12, 2025 11:48
@srebhan srebhan modified the milestones: v1.35.0, v1.34.4 May 12, 2025
srebhan pushed a commit that referenced this pull request May 19, 2025
@elv-gilles @srebhan
fix(parsers.json_v2): Handle measurements with multiple objects corre…
2976a2b 
…ctly (#16878)

(cherry picked from commit c31d402)
@BrewTestBot BrewTestBot mentioned this pull request May 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skartikey skartikey skartikey approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@skartikey skartikey

@mstrandboge mstrandboge

Labels

area/json json and json_v2 parser/serialiser related fix pr to fix corresponding bug plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Milestone

v1.34.4

Development

Successfully merging this pull request may close these issues.

json_v2 parser multiple measurements mixed

4 participants

@elv-gilles @skartikey @srebhan @mstrandboge