Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(deps): Bump github.com/facebook/time to latest #17563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2025
Merged

chore(deps): Bump github.com/facebook/time to latest #17563

merged 1 commit into from
Sep 4, 2025

Conversation

@skartikey
Copy link
Contributor

@skartikey skartikey commented Sep 3, 2025 •
edited
Loading

Summary

Updated go.mod to latest facebook/time (includes my upstream fix).
This introduced a type change (ReplyNTPSourceName.Name → string), causing compilation errors.

PR updates:

  1. Bump dependency to latest version
  2. Fix code to handle string type ([]byte(sourceName.Name), remove redundant string() casts)

Chrony plugin now builds and all tests pass.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #17453

@telegraf-tiger telegraf-tiger bot added the chore label Sep 3, 2025
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Sep 3, 2025

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

. DEB . RPM . TAR . GZ . ZIP
[[amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip] [arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip] [armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip] [armhf.deb i386.rpm freebsd_armv7.tar.gz ] [i386.deb ppc64le.rpm freebsd_i386.tar.gz ] [mips.deb riscv64.rpm linux_amd64.tar.gz ] [mipsel.deb s390x.rpm linux_arm64.tar.gz ] [ppc64el.deb x86_64.rpm linux_armel.tar.gz ] [riscv64.deb linux_armhf.tar.gz ] [s390x.deb linux_i386.tar.gz ] [ linux_mips.tar.gz ] [ linux_mipsel.tar.gz ] [ linux_ppc64le.tar.gz ] [ linux_riscv64.tar.gz ] [ linux_s390x.tar.gz ]]

@srebhan srebhan added the dependencies Pull requests that update a dependency file label Sep 3, 2025
@mstrandboge mstrandboge removed their assignment Sep 3, 2025
@mstrandboge mstrandboge added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 3, 2025
@srebhan srebhan merged commit 6c0bdab into influxdata:master Sep 4, 2025
31 checks passed
@github-actions github-actions bot added this to the v1.36.0 milestone Sep 4, 2025
skartikey added a commit to skartikey/telegraf that referenced this pull request Sep 5, 2025
@skartikey
chore(deps): Bump github.com/facebook/time to latest (influxdata#17563)
4c55c38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srebhan srebhan srebhan approved these changes

@mstrandboge mstrandboge mstrandboge approved these changes

Assignees

@srebhan srebhan

Labels

chore dependencies Pull requests that update a dependency file ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Milestone

v1.36.0

Development

Successfully merging this pull request may close these issues.

Panic in chrony input plugin

3 participants

@skartikey @srebhan @mstrandboge