Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix wrong property in docs #2593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2025
Merged

Fix wrong property in docs #2593

merged 1 commit into from
Oct 27, 2025

Conversation

@Koen-Reefman
Copy link
Contributor

What I did

  1. I changed hidesOnEscape to hidesOnEsc in the docs - now, you can't close the overlay with escape if you set this property to false

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2025

⚠️ No Changeset found

Latest commit: 33808c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Koen Reefman seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gerjanvangeest
Copy link
Member

Thanks for the fix @Koen-Reefman 💪

@gerjanvangeest gerjanvangeest merged commit f385bed into ing-bank:master Oct 27, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gerjanvangeest gerjanvangeest gerjanvangeest approved these changes

@tlouisse tlouisse Awaiting requested review from tlouisse tlouisse is a code owner

@narzac narzac Awaiting requested review from narzac narzac is a code owner

@Knorgias Knorgias Awaiting requested review from Knorgias Knorgias is a code owner

@okadurin okadurin Awaiting requested review from okadurin okadurin is a code owner

@ryubro ryubro Awaiting requested review from ryubro ryubro is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Koen-Reefman @CLAassistant @gerjanvangeest