Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: add supported product id #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

fix: add supported product id #390

merged 1 commit into from
Apr 17, 2025

Conversation

@beer-1
Copy link
Member

@beer-1 beer-1 commented Apr 16, 2025

Description

When I have test the recently brought ledger devices, those devises are returning following product ids.

// The USB product IDs will be defined as MMII, encoding a model (MM) and an interface bitfield (II)
0x1000, /* Ledger Nano S */
0x4000, /* Ledger Nano X */
0x5000, /* Ledger Nano S Plus */
0x6000, /* Ledger Nano FTS */

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@beer-1 beer-1 requested a review from a team as a code owner April 16, 2025 06:33
@beer-1 beer-1 self-assigned this Apr 16, 2025
@coderabbitai
Copy link

coderabbitai bot commented Apr 16, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

The change updates the Ledger USB wallet hub by adding four new USB product IDs to the list of recognized Ledger devices. These product IDs correspond to various models and interface combinations for Ledger Nano S, Nano X, Nano S Plus, and Nano FTS devices. The update extends the set of supported hardware wallets by including these new identifiers in the initialization of the Ledger hub, without altering any public function signatures or interfaces.

Changes

File(s) Change Summary
crypto/ledger/usbwallet/hub.go Added four new USB product IDs for Ledger devices in the NewLedgerHub function's supported list.

Poem

Four new IDs hop in, a digital parade,
Nano S, X, Plus, FTS—support now displayed.
The hub grows wiser, its warren expands,
Recognizing more friends with binary hands.
As wallets connect, the future feels bright—
More bunnies with ledgers, all hopping in light! 🐇✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fe0f39b and d074e5c.

📒 Files selected for processing (1)
  • crypto/ledger/usbwallet/hub.go (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: golangci-lint
  • GitHub Check: Run test and upload codecov
  • GitHub Check: Analyze (go)
🔇 Additional comments (1)
crypto/ledger/usbwallet/hub.go (1)

98-103: LGTM: Added support for new Ledger USB product IDs

The addition of these four product IDs (0x1000, 0x4000, 0x5000, 0x6000) for Ledger devices is well-structured and properly documented. The comment clearly explains the MMII format where MM represents the model and II is the interface bitfield. This change correctly extends support for recently purchased Ledger devices while maintaining compatibility with existing ones.

✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@beer-1 beer-1 requested a review from sh-cha April 16, 2025 06:34
@github-actions
Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@beer-1 beer-1 requested a review from Vritra4 April 16, 2025 06:46
@codecov
Copy link

codecov bot commented Apr 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 40.06%. Comparing base (92df11e) to head (d074e5c).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crypto/ledger/usbwallet/hub.go 0.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
- Coverage   40.07%   40.06%   -0.01%     
==========================================
  Files         294      294              
  Lines       27511    27517       +6     
==========================================
  Hits        11025    11025              
- Misses      14785    14791       +6     
  Partials     1701     1701
Files with missing lines Coverage Δ
crypto/ledger/usbwallet/hub.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@beer-1 beer-1 added v1 Release v1 cli labels Apr 17, 2025
@beer-1 beer-1 merged commit 80e6b70 into main Apr 17, 2025
9 of 10 checks passed
@beer-1 beer-1 deleted the fix/support-latest-ledger-protocol branch April 17, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sh-cha sh-cha Awaiting requested review from sh-cha

@Vritra4 Vritra4 Awaiting requested review from Vritra4

Assignees

@beer-1 beer-1

Labels

cli v1 Release v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@beer-1