fix: use gas price at mempool priority instead of fee amount #408

beer-1 · 2025-05-23T05:06:55Z

Description

Closes: #407

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

included the correct type prefix in the PR title, you can find examples of the prefixes below:
confirmed ! in the type prefix if API or client breaking change
targeted the correct branch
provided a link to the relevant issue or specification
reviewed "Files changed" and left comments if necessary
included the necessary unit and integration tests
updated the relevant documentation or specification, including comments for documenting Go code
confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed all author checklist items have been addressed
reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

coderabbitai · 2025-05-23T05:07:01Z

📝 Walkthrough

Walkthrough

The code updates the calculation of transaction priority in the mempool by basing it on gas price rather than total fee amount. Corresponding tests are updated to assert the correct priority values under different transaction contexts, ensuring the new logic is validated.

Changes

File(s)	Change Summary
x/dynamic-fee/ante/fee.go	Replaces priority calculation: now uses max(gas price × 1,000,000, 1) instead of total fee amount.
x/dynamic-fee/ante/fee_test.go	Updates tests to assert expected priority values based on the new gas price-based calculation.

Sequence Diagram(s)

sequenceDiagram
    participant Tx as Transaction
    participant FeeChecker as MempoolFeeChecker

    Tx->>FeeChecker: Submit transaction (with fee, gas)
    FeeChecker->>FeeChecker: Calculate gas price from total fee
    FeeChecker->>FeeChecker: Set priority = max(gas price × 1,000,000, 1)
    FeeChecker-->>Tx: Return priority and error (if any)

Assessment against linked issues

Objective	Addressed	Explanation
Prioritize mempool transactions by gas price, not total fee amount (#407)	✅

Poem

A clever change, a rabbit grins,
Now gas price, not fee, decides who wins.
No longer do big spenders rule the queue,
Efficiency matters—hoppity-hoo!
With tests in place, all is bright,
The mempool now feels just right.
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b2be46d and b369832.

📒 Files selected for processing (2)

x/dynamic-fee/ante/fee.go (1 hunks)
x/dynamic-fee/ante/fee_test.go (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: golangci-lint
GitHub Check: Run test and upload codecov
GitHub Check: Analyze (go)

🔇 Additional comments (3)

x/dynamic-fee/ante/fee.go (1)

72-73: Improved transaction prioritization logic

The change correctly modifies transaction priority calculation to use gas price instead of fee amount, which is a more accurate measure of what a user is willing to pay per unit of computation. Multiplying by 1,000,000 converts the decimal gas price to a usable integer value while maintaining precision, and the max function ensures a minimum priority of 1.

This approach:

Prevents users from artificially increasing priority with unnecessarily high gas limits

Aligns with blockchain fee market best practices

Provides fairer transaction ordering in the mempool

x/dynamic-fee/ante/fee_test.go (2)

116-118: LGTM: DeliverTx priority test added

Good addition of the priority assertion for DeliverTx mode. This verifies that transactions have the minimum priority value (1) when not in CheckTx mode, which is the expected behavior since transaction priority is only meaningful for mempool sorting.

128-130: LGTM: CheckTx priority test added

Well-implemented test case that verifies the new priority calculation formula. The assertion correctly checks that a gas price of 0.0005 results in a priority of 500 (0.0005 * 1,000,000), confirming that the new calculation logic works as expected in CheckTx mode.

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-05-23T05:07:09Z

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

codecov · 2025-05-23T05:21:12Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.15%. Comparing base (b2be46d) to head (b369832).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #408   +/-   ##
=======================================
  Coverage   40.15%   40.15%           
=======================================
  Files         295      295           
  Lines       27726    27726           
=======================================
  Hits        11132    11132           
  Misses      14883    14883           
  Partials     1711     1711

Files with missing lines	Coverage Δ
x/dynamic-fee/ante/fee.go	`84.00% <100.00%> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ALPAC-4

LGTM

fix to use gas price at mempool priority instead of fee amount

b369832

beer-1 self-assigned this May 23, 2025

beer-1 requested a review from a team as a code owner May 23, 2025 05:06

ALPAC-4 approved these changes May 23, 2025

View reviewed changes

beer-1 merged commit 5198b26 into main May 23, 2025
11 checks passed

beer-1 deleted the fix/mempool-priority branch May 23, 2025 06:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: use gas price at mempool priority instead of fee amount #408

fix: use gas price at mempool priority instead of fee amount #408

Uh oh!

beer-1 commented May 23, 2025

Uh oh!

coderabbitai bot commented May 23, 2025 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Assessment against linked issues

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented May 23, 2025

Uh oh!

codecov bot commented May 23, 2025 •

edited

Loading

Uh oh!

ALPAC-4 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

fix: use gas price at mempool priority instead of fee amount #408

fix: use gas price at mempool priority instead of fee amount #408

Uh oh!

Conversation

beer-1 commented May 23, 2025

Description

Author Checklist

Reviewers Checklist

Uh oh!

coderabbitai bot commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Assessment against linked issues

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented May 23, 2025

Dependency Review

Scanned Files

Uh oh!

codecov bot commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ALPAC-4 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented May 23, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented May 23, 2025 •

edited

Loading