This repository was archived by the owner on Aug 26, 2022. It is now read-only.
Feature: adds redis as a dependency for the uidp helm chart #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 11, 2021 12:49
Codecov Report
@@ Coverage Diff @@
## develop #111 +/- ##
========================================
Coverage 75.02% 75.02%
========================================
Files 116 116
Lines 6382 6382
========================================
Hits 4788 4788
Misses 1356 1356
Partials 238 238
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
lucasABLima
approved these changes
Aug 11, 2021
| command: | ||
| - "sh" | ||
| - "-c" | ||
| - "until curl -s {{ include "uidp.redis.address" $ }}; do echo waiting for redis; sleep 2; done" |
There was a problem hiding this comment.
This is interesting
LucasStarlingdePaulaSalles
approved these changes
Aug 13, 2021
|
LGTM |
nicholaspcr
approved these changes
Aug 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Kind: feature
Section: helm chart
Summary: adds redis cluster as a dependency for the uidp helm chart
Changelog
Pay attention to
Secret name sharing and templating