Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Aug 26, 2022. It is now read-only.

Story CORE-574 | Develop metrics for the sidecar broker Writer #129

Merged
merged 7 commits into from
Sep 16, 2021
Merged

Story CORE-574 | Develop metrics for the sidecar broker Writer #129

merged 7 commits into from
Sep 16, 2021

Conversation

@luiz-couto
Copy link
Contributor

Description

Kind: Feature

Section: Kafka Writer

Summary: Added kafka writer metrics

Changelog

  • Added metrics to the kafka writer structure
  • Created GetMetrics function inside kafka writer
  • Added metric for the resolve channel duration
  • Added metric for the produce message duration
  • Added metric for the flush duration

@luiz-couto luiz-couto requested a review from a team as a code owner September 15, 2021 15:00
@codecov
Copy link

codecov bot commented Sep 15, 2021 •
edited
Loading

Codecov Report

Merging #129 (cd7c4c3) into develop (964f017) will increase coverage by 0.51%.
The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #129      +/-   ##
===========================================
+ Coverage    75.05%   75.56%   +0.51%     
===========================================
  Files          116      117       +1     
  Lines         6538     6606      +68     
===========================================
+ Hits          4907     4992      +85     
+ Misses        1391     1371      -20     
- Partials       240      243       +3
Flag Coverage Δ
unittests 75.56% <91.66%> (+0.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/api/handlers/token_handler.go 5.63% <0.00%> (+0.15%) ⬆️
pkg/controller/client/auth.go 100.00% <ø> (ø)
pkg/sidecars/server/handlers.go 50.60% <66.66%> (-6.55%) ⬇️
pkg/rest/middleware.go 95.50% <73.33%> (-4.50%) ⬇️
cmd/insprd/operators/nodes/converter.go 72.11% <100.00%> (-0.23%) ⬇️
cmd/sidecars/kafka/client/writer.go 89.24% <100.00%> (+12.50%) ⬆️
cmd/uidp/client/client.go 68.42% <100.00%> (+0.48%) ⬆️
pkg/auth/models.go 100.00% <100.00%> (ø)
pkg/rest/request/client.go 100.00% <100.00%> (ø)
pkg/sidecars/server/server.go 78.94% <100.00%> (+28.42%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29347f1...cd7c4c3. Read the comment docs.

LucasStarlingdePaulaSalles
LucasStarlingdePaulaSalles suggested changes Sep 15, 2021
View reviewed changes
@luiz-couto luiz-couto merged commit 672c435 into develop Sep 16, 2021
@luiz-couto luiz-couto deleted the story/CORE-574 branch September 16, 2021 13:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nicholaspcr nicholaspcr Awaiting requested review from nicholaspcr

@ptcar2009 ptcar2009 Awaiting requested review from ptcar2009

2 more reviewers

@lucasABLima lucasABLima lucasABLima approved these changes

@LucasStarlingdePaulaSalles LucasStarlingdePaulaSalles LucasStarlingdePaulaSalles approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@luiz-couto @lucasABLima @LucasStarlingdePaulaSalles