This repository was archived by the owner on Aug 26, 2022. It is now read-only.
Story CORE-502 | Develop client ( for controller dApps) for Python #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… receiving params
Codecov Report
@@ Coverage Diff @@
## develop #120 +/- ##
========================================
Coverage 74.93% 74.93%
========================================
Files 116 116
Lines 6384 6384
========================================
Hits 4784 4784
Misses 1362 1362
Partials 238 238
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
lucasABLima
approved these changes
Aug 26, 2021
nicholaspcr
approved these changes
Aug 26, 2021
LucasStarlingdePaulaSalles
approved these changes
Aug 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Kind: Feature
Section: Python Controller Client
Summary: Created Python Controller Client.
Changelog
The following modules were added to inspr python lib:
Pay attention to
It was decided to create separated endpoints for eachone of the structures, as this leads to more specific functions that helps the user when using the client.
Making the client too general (like a single GET function etc), makes the client lose some of its function, which is to make it easier for the user to interact with the Insprd API/endpoints. If it is very general and the
user has to define the body, it wouldn't be much different from implementing a get function of his own (in the user perspective).