Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Aug 26, 2022. It is now read-only.

Story CORE-581 | [BETA] Create a function to resolve Routes #138

Merged
merged 6 commits into from
Sep 27, 2021
Merged

Story CORE-581 | [BETA] Create a function to resolve Routes #138

merged 6 commits into from
Sep 27, 2021

Conversation

@LucasStarlingdePaulaSalles
Copy link
Contributor

Description

Kind: Feature

Section: Memory, Node Operator

Summary: Resolution for routes on compound dApp structures

Changelog

@LucasStarlingdePaulaSalles LucasStarlingdePaulaSalles requested a review from a team as a code owner September 27, 2021 14:09
@LucasStarlingdePaulaSalles LucasStarlingdePaulaSalles changed the title Story/core 581 Story CORE-581 | [BETA] Create a function to resolve Routes Sep 27, 2021
@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #138 (eb30bd1) into develop (964f017) will increase coverage by 0.63%.
The diff coverage is 89.88%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #138      +/-   ##
===========================================
+ Coverage    75.05%   75.68%   +0.63%     
===========================================
  Files          116      117       +1     
  Lines         6538     6671     +133     
===========================================
+ Hits          4907     5049     +142     
+ Misses        1391     1376      -15     
- Partials       240      246       +6
Flag Coverage Δ
unittests 75.68% <89.88%> (+0.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/api/handlers/token_handler.go 5.63% <0.00%> (+0.15%) ⬆️
pkg/controller/client/auth.go 100.00% <ø> (ø)
pkg/rest/request/request.go 93.65% <ø> (ø)
pkg/utils/string_slice.go 70.21% <20.00%> (-3.60%) ⬇️
cmd/insprd/operators/nodes/converter.go 71.70% <66.66%> (-0.63%) ⬇️
pkg/sidecars/server/handlers.go 50.60% <66.66%> (-6.55%) ⬇️
pkg/rest/middleware.go 95.50% <73.33%> (-4.50%) ⬇️
cmd/sidecars/kafka/client/reader.go 81.65% <92.30%> (+3.33%) ⬆️
cmd/insprctl/cli/apply_type.go 68.18% <100.00%> (+3.18%) ⬆️
cmd/insprd/memory/tree/dapp_utils.go 87.80% <100.00%> (+1.54%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55360ec...eb30bd1. Read the comment docs.

@LucasStarlingdePaulaSalles LucasStarlingdePaulaSalles merged commit 7958ce7 into develop Sep 27, 2021
@LucasStarlingdePaulaSalles LucasStarlingdePaulaSalles deleted the story/CORE-581 branch September 27, 2021 17:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@lucasABLima lucasABLima lucasABLima approved these changes

@luiz-couto luiz-couto luiz-couto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LucasStarlingdePaulaSalles @lucasABLima @luiz-couto