Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Aug 26, 2022. It is now read-only.

Story CORE-575 | Develop metrics for the sidecar broker Reader #130

Merged
merged 18 commits into from
Sep 16, 2021
Merged

Story CORE-575 | Develop metrics for the sidecar broker Reader #130

merged 18 commits into from
Sep 16, 2021

Conversation

@lucasABLima
Copy link
Contributor

Description

Kind: Feature

Section: Kafka Reader

Summary: Added kafka reader metrics

Changelog

  • Added metrics to the kafka reader structure
  • Created GetMetrics function inside kafka reader
  • Added metric for the resolve channel duration

@lucasABLima lucasABLima requested a review from a team as a code owner September 15, 2021 17:58
@codecov
Copy link

codecov bot commented Sep 15, 2021 •
edited
Loading

Codecov Report

Merging #130 (4cf285f) into develop (964f017) will increase coverage by 0.59%.
The diff coverage is 92.08%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #130      +/-   ##
===========================================
+ Coverage    75.05%   75.64%   +0.59%     
===========================================
  Files          116      117       +1     
  Lines         6538     6636      +98     
===========================================
+ Hits          4907     5020     +113     
+ Misses        1391     1372      -19     
- Partials       240      244       +4
Flag Coverage Δ
unittests 75.64% <92.08%> (+0.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/api/handlers/token_handler.go 5.63% <0.00%> (+0.15%) ⬆️
pkg/controller/client/auth.go 100.00% <ø> (ø)
pkg/sidecars/server/handlers.go 50.60% <66.66%> (-6.55%) ⬇️
pkg/rest/middleware.go 95.50% <73.33%> (-4.50%) ⬇️
cmd/sidecars/kafka/client/reader.go 81.65% <92.30%> (+3.33%) ⬆️
cmd/insprd/operators/nodes/converter.go 72.11% <100.00%> (-0.23%) ⬇️
cmd/sidecars/kafka/client/writer.go 89.24% <100.00%> (+12.50%) ⬆️
cmd/uidp/client/client.go 68.42% <100.00%> (+0.48%) ⬆️
pkg/auth/models.go 100.00% <100.00%> (ø)
pkg/rest/request/client.go 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2b9d30...4cf285f. Read the comment docs.

@lucasABLima lucasABLima merged commit ac6f7c4 into develop Sep 16, 2021
@lucasABLima lucasABLima deleted the story/CORE-575 branch September 16, 2021 15:16
@lucasABLima lucasABLima changed the title Story/core 575 | Develop metrics for the sidecar broker Reader Story CORE-575 | Develop metrics for the sidecar broker Reader Sep 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@luiz-couto luiz-couto Awaiting requested review from luiz-couto

2 more reviewers

@nicholaspcr nicholaspcr nicholaspcr approved these changes

@LucasStarlingdePaulaSalles LucasStarlingdePaulaSalles LucasStarlingdePaulaSalles approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lucasABLima @nicholaspcr @LucasStarlingdePaulaSalles