Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Aug 26, 2022. It is now read-only.

Story CORE-576 | Reconfigure Kafka to verify that its deployment isn't the problem #132

Merged
merged 3 commits into from
Sep 17, 2021
Merged

Story CORE-576 | Reconfigure Kafka to verify that its deployment isn't the problem #132

merged 3 commits into from
Sep 17, 2021

Conversation

@nicholaspcr
Copy link
Contributor

@nicholaspcr nicholaspcr commented Sep 16, 2021 •
edited
Loading

Description

Kind: story

Section: kafka/client

Summary: removed the producer.Flush() from the writer to allow for asynchronous communication, doc

@codecov
Copy link

codecov bot commented Sep 16, 2021 •
edited
Loading

Codecov Report

Merging #132 (f4ef5fd) into develop (964f017) will increase coverage by 0.55%.
The diff coverage is 91.53%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #132      +/-   ##
===========================================
+ Coverage    75.05%   75.60%   +0.55%     
===========================================
  Files          116      117       +1     
  Lines         6538     6624      +86     
===========================================
+ Hits          4907     5008     +101     
+ Misses        1391     1372      -19     
- Partials       240      244       +4
Flag Coverage Δ
unittests 75.60% <91.53%> (+0.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/api/handlers/token_handler.go 5.63% <0.00%> (+0.15%) ⬆️
pkg/controller/client/auth.go 100.00% <ø> (ø)
pkg/rest/request/request.go 93.65% <ø> (ø)
pkg/sidecars/server/handlers.go 50.60% <66.66%> (-6.55%) ⬇️
pkg/rest/middleware.go 95.50% <73.33%> (-4.50%) ⬇️
cmd/sidecars/kafka/client/reader.go 81.65% <92.30%> (+3.33%) ⬆️
cmd/insprd/operators/nodes/converter.go 72.11% <100.00%> (-0.23%) ⬇️
cmd/sidecars/kafka/client/writer.go 87.65% <100.00%> (+10.91%) ⬆️
cmd/uidp/client/client.go 68.42% <100.00%> (+0.48%) ⬆️
pkg/auth/models.go 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7257749...f4ef5fd. Read the comment docs.

@LucasStarlingdePaulaSalles LucasStarlingdePaulaSalles marked this pull request as ready for review September 17, 2021 17:15
@LucasStarlingdePaulaSalles LucasStarlingdePaulaSalles requested a review from a team as a code owner September 17, 2021 17:15
@luiz-couto luiz-couto merged commit 19f0158 into develop Sep 17, 2021
@luiz-couto luiz-couto deleted the story/CORE-576 branch September 17, 2021 17:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@luiz-couto luiz-couto luiz-couto approved these changes

@LucasStarlingdePaulaSalles LucasStarlingdePaulaSalles LucasStarlingdePaulaSalles approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nicholaspcr @luiz-couto @LucasStarlingdePaulaSalles