Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Aug 26, 2022. It is now read-only.

Story CORE-592 | [BETA] Create Route metrics to assert throughput. #146

Merged
merged 26 commits into from
Oct 13, 2021
Merged

Story CORE-592 | [BETA] Create Route metrics to assert throughput. #146

merged 26 commits into from
Oct 13, 2021

Conversation

@lucasABLima
Copy link
Contributor

@lucasABLima lucasABLima commented Oct 7, 2021 •
edited
Loading

Description

Kind: Story

Section: Pkg lbsidecar

Summary: Create send and handle summary and error count metrics to the BETA route feature.

Changelog

  • added metrics to the route send and handle structure
  • created GetMetricHandlerRoute function inside the lbsidecar server
  • created GetMetricSenderRoute function inside the lbsidecar server
  • added metric for the resolve route send duration
  • added metric for the produce route handle duration

@lucasABLima lucasABLima requested a review from a team as a code owner October 7, 2021 12:32
@codecov
Copy link

codecov bot commented Oct 7, 2021 •
edited
Loading

Codecov Report

Merging #146 (7ff0f67) into develop (964f017) will increase coverage by 1.14%.
The diff coverage is 91.95%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #146      +/-   ##
===========================================
+ Coverage    75.05%   76.19%   +1.14%     
===========================================
  Files          116      117       +1     
  Lines         6538     6856     +318     
===========================================
+ Hits          4907     5224     +317     
+ Misses        1391     1383       -8     
- Partials       240      249       +9
Flag Coverage Δ
unittests 76.19% <91.95%> (+1.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/api/handlers/token_handler.go 5.63% <0.00%> (+0.15%) ⬆️
pkg/controller/client/auth.go 100.00% <ø> (ø)
pkg/utils/string_slice.go 70.21% <20.00%> (-3.60%) ⬇️
pkg/sidecars/server/handlers.go 50.60% <66.66%> (-6.55%) ⬇️
pkg/rest/middleware.go 95.50% <73.33%> (-4.50%) ⬇️
cmd/insprd/operators/nodes/converter.go 72.45% <85.00%> (+0.12%) ⬆️
pkg/sidecars/lbsidecar/handlers.go 81.28% <90.41%> (+4.48%) ⬆️
cmd/sidecars/kafka/client/reader.go 81.65% <92.30%> (+3.33%) ⬆️
pkg/client/client.go 91.22% <93.22%> (+1.22%) ⬆️
pkg/sidecars/server/server.go 79.79% <93.33%> (+29.27%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 938407b...7ff0f67. Read the comment docs.

@lucasABLima lucasABLima changed the title Story CORE-592 | [BETA] create Route metrics to assert throughput. Story CORE-592 | [BETA] Create Route metrics to assert throughput. Oct 7, 2021
LucasStarlingdePaulaSalles
LucasStarlingdePaulaSalles reviewed Oct 13, 2021
View reviewed changes
@lucasABLima lucasABLima merged commit 59b1219 into develop Oct 13, 2021
@lucasABLima lucasABLima deleted the story/CORE-592 branch October 13, 2021 13:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ptcar2009 ptcar2009 Awaiting requested review from ptcar2009

2 more reviewers

@luiz-couto luiz-couto luiz-couto approved these changes

@LucasStarlingdePaulaSalles LucasStarlingdePaulaSalles LucasStarlingdePaulaSalles approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lucasABLima @luiz-couto @LucasStarlingdePaulaSalles