Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Aug 26, 2022. It is now read-only.

Story CORE-591 | Implement benchmarking dapp out of Inspr Stack #147

Merged
merged 12 commits into from
Oct 8, 2021
Merged

Story CORE-591 | Implement benchmarking dapp out of Inspr Stack #147

merged 12 commits into from
Oct 8, 2021

Conversation

@LucasStarlingdePaulaSalles
Copy link
Contributor

Description

Kind: Story

Section: Examples

Summary: An example of write-read kafka dapps without the use of Inspr

Changelog

  • feature:
    • implemented k8s job for creating "kafka-test" topic on kafka
    • implemented k8s job for deleting "kafka-test" topic on kafka
    • implemented k8s deployment for app that sends messages non stop on "kafka-test" topic
    • implemented k8s deployment for app that reads messages non stop from "kafka-test" topic
    • created Makefile and dockerfiles to compile images

Pay attention to

Important parts of the code that require special attention

@LucasStarlingdePaulaSalles LucasStarlingdePaulaSalles requested a review from a team as a code owner October 7, 2021 16:05
@codecov
Copy link

codecov bot commented Oct 7, 2021 •
edited
Loading

Codecov Report

Merging #147 (b79b994) into develop (964f017) will increase coverage by 0.85%.
The diff coverage is 91.45%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #147      +/-   ##
===========================================
+ Coverage    75.05%   75.91%   +0.85%     
===========================================
  Files          116      117       +1     
  Lines         6538     6754     +216     
===========================================
+ Hits          4907     5127     +220     
+ Misses        1391     1380      -11     
- Partials       240      247       +7
Flag Coverage Δ
unittests 75.91% <91.45%> (+0.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/api/handlers/token_handler.go 5.63% <0.00%> (+0.15%) ⬆️
pkg/controller/client/auth.go 100.00% <ø> (ø)
pkg/utils/string_slice.go 70.21% <20.00%> (-3.60%) ⬇️
pkg/sidecars/server/handlers.go 50.60% <66.66%> (-6.55%) ⬇️
cmd/insprd/operators/nodes/converter.go 71.70% <70.00%> (-0.63%) ⬇️
pkg/rest/middleware.go 95.50% <73.33%> (-4.50%) ⬇️
pkg/sidecars/lbsidecar/handlers.go 80.57% <91.07%> (+3.77%) ⬆️
cmd/sidecars/kafka/client/reader.go 81.65% <92.30%> (+3.33%) ⬆️
cmd/insprctl/cli/apply_type.go 68.18% <100.00%> (+3.18%) ⬆️
cmd/insprd/memory/tree/dapp_utils.go 87.98% <100.00%> (+1.71%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa8ef45...b79b994. Read the comment docs.

luiz-couto
luiz-couto reviewed Oct 8, 2021
View reviewed changes
examples/kafka_standalone/reader/reader.Dockerfile Outdated
COPY go.mod go.mod
RUN go mod download
COPY . .
# RUN go build -o main examples/kafka_standalone/topic/create.go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment needed?

luiz-couto
luiz-couto reviewed Oct 8, 2021
View reviewed changes
examples/kafka_standalone/topic/create/create.Dockerfile Outdated
COPY go.mod go.mod
RUN go mod download
COPY . .
# RUN go build -o main examples/kafka_standalone/topic/create.go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this one?

luiz-couto
luiz-couto reviewed Oct 8, 2021
View reviewed changes
examples/kafka_standalone/topic/delete/delete.Dockerfile Outdated
COPY go.mod go.mod
RUN go mod download
COPY . .
# RUN go build -o main examples/kafka_standalone/topic/create.go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this?

luiz-couto
luiz-couto reviewed Oct 8, 2021
View reviewed changes
examples/kafka_standalone/writer/writer.go Outdated
}()
time.Sleep(5 * time.Second)

// delivery_chan := make(chan kafka.Event, 10000)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one too

luiz-couto
luiz-couto suggested changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@luiz-couto luiz-couto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove unnecessary comments

@LucasStarlingdePaulaSalles LucasStarlingdePaulaSalles merged commit ba08870 into develop Oct 8, 2021
@LucasStarlingdePaulaSalles LucasStarlingdePaulaSalles deleted the story/CORE-591 branch October 8, 2021 12:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@lucasABLima lucasABLima lucasABLima approved these changes

@luiz-couto luiz-couto luiz-couto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LucasStarlingdePaulaSalles @lucasABLima @luiz-couto