Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Aug 26, 2022. It is now read-only.

Story CORE-600 | Add metrics to the throughput apps without inspr #149

Merged
merged 4 commits into from
Oct 13, 2021
Merged

Story CORE-600 | Add metrics to the throughput apps without inspr #149

merged 4 commits into from
Oct 13, 2021

Conversation

@LucasStarlingdePaulaSalles
Copy link
Contributor

Description

Kind: story

Section: Examples

Summary: Added metrics to the throughput apps for Kafka without inspr

Changelog

  • features:
    • added duration metrics for writes and reads

@LucasStarlingdePaulaSalles LucasStarlingdePaulaSalles requested a review from a team as a code owner October 8, 2021 18:23
@codecov
Copy link

codecov bot commented Oct 8, 2021 •
edited
Loading

Codecov Report

Merging #149 (b54c899) into develop (964f017) will increase coverage by 0.86%.
The diff coverage is 91.51%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #149      +/-   ##
===========================================
+ Coverage    75.05%   75.91%   +0.86%     
===========================================
  Files          116      117       +1     
  Lines         6538     6756     +218     
===========================================
+ Hits          4907     5129     +222     
+ Misses        1391     1380      -11     
- Partials       240      247       +7
Flag Coverage Δ
unittests 75.91% <91.51%> (+0.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/api/handlers/token_handler.go 5.63% <0.00%> (+0.15%) ⬆️
pkg/controller/client/auth.go 100.00% <ø> (ø)
pkg/utils/string_slice.go 70.21% <20.00%> (-3.60%) ⬇️
pkg/sidecars/server/handlers.go 50.60% <66.66%> (-6.55%) ⬇️
cmd/insprd/operators/nodes/converter.go 71.70% <70.00%> (-0.63%) ⬇️
pkg/rest/middleware.go 95.50% <73.33%> (-4.50%) ⬇️
pkg/sidecars/lbsidecar/handlers.go 80.79% <91.37%> (+3.99%) ⬆️
cmd/sidecars/kafka/client/reader.go 81.65% <92.30%> (+3.33%) ⬆️
cmd/insprctl/cli/apply_type.go 68.18% <100.00%> (+3.18%) ⬆️
cmd/insprd/memory/tree/dapp_utils.go 87.98% <100.00%> (+1.71%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5531c7c...b54c899. Read the comment docs.

lucasABLima
lucasABLima reviewed Oct 13, 2021
View reviewed changes
@LucasStarlingdePaulaSalles LucasStarlingdePaulaSalles merged commit 938407b into develop Oct 13, 2021
@LucasStarlingdePaulaSalles LucasStarlingdePaulaSalles deleted the story/CORE-600 branch October 13, 2021 12:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@lucasABLima lucasABLima lucasABLima approved these changes

@luiz-couto luiz-couto luiz-couto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LucasStarlingdePaulaSalles @lucasABLima @luiz-couto