Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Aug 26, 2022. It is now read-only.

Story CORE-589 | [BETA] dApp client HandleRoute #141

Merged
merged 10 commits into from
Sep 30, 2021
Merged

Story CORE-589 | [BETA] dApp client HandleRoute #141

merged 10 commits into from
Sep 30, 2021

Conversation

@luiz-couto
Copy link
Contributor

Description

Kind: Feature

Section: Client

Summary: Added handle route function

Changelog

  • Created Handle Route function
  • Created an "add handle to mux" helper function for the handle channel and handle route
  • Added tests for handle route

@luiz-couto luiz-couto requested a review from a team as a code owner September 30, 2021 12:22
@codecov
Copy link

codecov bot commented Sep 30, 2021 •
edited
Loading

Codecov Report

Merging #141 (84720a3) into develop (964f017) will increase coverage by 0.83%.
The diff coverage is 91.27%.

❗ Current head 84720a3 differs from pull request most recent head 8d0ce43. Consider uploading reports for the commit 8d0ce43 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #141      +/-   ##
===========================================
+ Coverage    75.05%   75.89%   +0.83%     
===========================================
  Files          116      117       +1     
  Lines         6538     6749     +211     
===========================================
+ Hits          4907     5122     +215     
+ Misses        1391     1380      -11     
- Partials       240      247       +7
Flag Coverage Δ
unittests 75.89% <91.27%> (+0.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/api/handlers/token_handler.go 5.63% <0.00%> (+0.15%) ⬆️
pkg/controller/client/auth.go 100.00% <ø> (ø)
pkg/utils/string_slice.go 70.21% <20.00%> (-3.60%) ⬇️
cmd/insprd/operators/nodes/converter.go 71.70% <66.66%> (-0.63%) ⬇️
pkg/sidecars/server/handlers.go 50.60% <66.66%> (-6.55%) ⬇️
pkg/rest/middleware.go 95.50% <73.33%> (-4.50%) ⬇️
pkg/sidecars/lbsidecar/handlers.go 81.42% <92.18%> (+4.62%) ⬆️
cmd/sidecars/kafka/client/reader.go 81.65% <92.30%> (+3.33%) ⬆️
cmd/insprctl/cli/apply_type.go 68.18% <100.00%> (+3.18%) ⬆️
cmd/insprd/memory/tree/dapp_utils.go 87.98% <100.00%> (+1.71%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 229749d...8d0ce43. Read the comment docs.

LucasStarlingdePaulaSalles
LucasStarlingdePaulaSalles suggested changes Sep 30, 2021
View reviewed changes
@luiz-couto luiz-couto merged commit ee5586e into develop Sep 30, 2021
@luiz-couto luiz-couto deleted the story/CORE-589 branch September 30, 2021 16:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@lucasABLima lucasABLima lucasABLima approved these changes

@LucasStarlingdePaulaSalles LucasStarlingdePaulaSalles LucasStarlingdePaulaSalles approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@luiz-couto @lucasABLima @LucasStarlingdePaulaSalles