Add pipelines and configs for llama as a teacher model #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aakanksha Duggal <[email protected]>
6c7d751 to
3af115f
Compare
jaideepr97
approved these changes
Apr 9, 2025
Member
jaideepr97
left a comment
There was a problem hiding this comment.
LGTM other than the one nit
not sure if grammatical syntax could affect the model's performance much
Co-authored-by: Jaideep Rao <[email protected]> Signed-off-by: Aakanksha Duggal <[email protected]>
Member
|
@bbrowning do you think we can get this merged? the CI failures are unrelated to this PR and are being handled within the instructlab repo as part of a separate effort I don't think we need to block this and #595 for this. we could get them merged and cut a new sdg release that will need to be consumed in instructlab anyway |
bbrowning
approved these changes
Apr 9, 2025
Contributor
bbrowning
left a comment
There was a problem hiding this comment.
Looks good. CI failures are unrelated, and happening after CI successfully completes SDG.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #594