-
Notifications
You must be signed in to change notification settings - Fork 56
Fix up mypy in recent CI testing (backport #616) #660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@Mergifyio rebase |
Contributor
Author
✅ Branch has been successfully rebased |
788f2c5 to
bfbb959
Compare
booxter
reviewed
Jun 9, 2025
Contributor
booxter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine; the warning issue in unit tests is fixed: #664
booxter
approved these changes
Jun 9, 2025
Contributor
|
@Mergifyio rebase |
Remove the cap on mypy and pydantic, since newer mypy are needed with our newest transformer builds. And, tell mypy to ignore this HybridChunker arg it doesn't understand since it gets handled in a non-standard way by Docling. Signed-off-by: Ben Browning <[email protected]> (cherry picked from commit 91319df)
During out coverage tests, pytest complains about an unraisable exception coming from Docling. Normally such an exception would be entirely ignored and unraised, but pytest is erroring out when it sees this exception. Docling behavior changed when it cannot find tesserocr recently by adding a garbage collection method on the tesseract model object, and if that fails to load properly it can throw this exception during garbage collection. However, it's a harmless exception since it failed to load anyway so we don't really care about it erroring out during garbage collection. Signed-off-by: Ben Browning <[email protected]> (cherry picked from commit 2b971b3)
Contributor
Author
✅ Branch has been successfully rebased |
bfbb959 to
c1bfc37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the cap on mypy and pydantic, since newer mypy are needed with our newest transformer builds. And, tell mypy to ignore this HybridChunker arg it doesn't understand since it gets handled in a non-standard way by Docling.
This is an automatic backport of pull request #616 done by Mergify.