adding gap between form elements skill and knowledge #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishnoianil
suggested changes
Oct 15, 2024
Member
vishnoianil
left a comment
There was a problem hiding this comment.
Looks good to me. One minor comment. Also can you please cherry-pick it to the release-1.0 branch as well
| <HelperText> | ||
| <HelperTextItem icon={<ExclamationCircleIcon />} variant={validLink}> | ||
| Please enter a valid URL. | ||
| Required field |
Member
There was a problem hiding this comment.
I think we need to update this text, given that it doesn't only check if the box is empty, but it also checks if the entered string is valid string. I think, let's rephrase it to "URL is required and must be a valid URL".
Collaborator
Author
There was a problem hiding this comment.
Sure I will update that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes : #149