Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@andybraren
Copy link
Contributor

@andybraren andybraren commented Oct 18, 2024

Definitely not perfect, but fixes a few things for now:

  • Swaps PNG for a crystal clear SVG
  • Switches background positioning to contain to always keep Lemmy in view and never stretched
  • Removes height-based width declaration (min-width: 100vh) to fix horizontal scrollbars from showing

Below I've also included what this would look like with the updated background image of #283, which removes the hard corners. Might tweak that a bit more.

cc @aevo98765

Before

Roughly approximating what's seen on a vertical monitor, a floating window, and a full 16:9 window.

2024-10-18 17 44 00

After

2024-10-18 17 50 40

Or with the new background image of #283:

2024-10-18 19 32 14

Removes height-based width declaration, adjusts background resizing to keep in full view, and swaps PNG with crisper SVG.

Signed-off-by: Andy Braren <[email protected]>
Copy link
Member

@nerdalert nerdalert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty!

@nerdalert nerdalert merged commit 0c4fb4e into instructlab:main Oct 20, 2024
@vishnoianil
Copy link
Member

@andybraren can you please cherry-pick to release-1.0 branch as well.

@vishnoianil vishnoianil added the cherry-pick-release-1.0 Label to cherry-pick PR from main to release-1.0 branch. label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-release-1.0 Label to cherry-pick PR from main to release-1.0 branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants