Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Aug 7, 2025. It is now read-only.

Ease version handling and folder layout #112

Merged
merged 3 commits into from
Sep 3, 2021
Merged

Ease version handling and folder layout #112

merged 3 commits into from
Sep 3, 2021

Conversation

@berndgassmann
Copy link
Contributor

@berndgassmann berndgassmann commented Sep 2, 2021 •
edited
Loading

  • Handle version by cmake/ad-rss-lib-version.cmake
  • Replace generated cmake files
  • Remove impl folder
  • Update map to latest v2.4.5_hotfix commit
  • Update version number to 4.4.2

Description

Fixes #

Where has this been tested?

  • Platform(s): ...
  • Library version: ...

Possible Drawbacks

This change is Reviewable

Ease version handling and folder layout
81b7919 
* Handle version by cmake/version.cmake
* Replace generated cmake files
* Remove impl folder
* Update map to latest v2.4.5_hotfix commit
* Update version number to 4.4.2

Change-Id: I194f17dbcfbdb46f1bf1b0fb1c94cca7c0efc022
ad_rss full source path
5c49d2a 
Change-Id: I6505c2489642dab9f20672513701c08f678fcffc
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2021 •
edited
Loading

Codecov Report

Merging #112 (81b7919) into master (b713d7c) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 81b7919 differs from pull request most recent head 5c49d2a. Consider uploading reports for the commit 5c49d2a to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #112   +/-   ##
=======================================
  Coverage   82.00%   82.01%           
=======================================
  Files         268      268           
  Lines       34835    34826    -9     
  Branches     6406     6399    -7     
=======================================
- Hits        28566    28561    -5     
  Misses        805      805           
+ Partials     5464     5460    -4
Impacted Files Coverage Δ
ad_rss/include/ad/rss/state/RssStateOperation.hpp 60.00% <ø> (ø)
...d_rss/include/ad/rss/unstructured/DebugDrawing.hpp 50.00% <ø> (ø)
ad_rss/include/ad/rss/unstructured/Geometry.hpp 35.89% <ø> (ø)
ad_rss/src/core/RssCheck.cpp 46.15% <ø> (ø)
ad_rss/src/core/RssResponseResolving.cpp 55.66% <ø> (ø)
ad_rss/src/core/RssSituationChecking.cpp 76.99% <ø> (ø)
ad_rss/src/core/RssSituationExtraction.cpp 79.20% <ø> (ø)
ad_rss/src/situation/Physics.cpp 44.91% <ø> (ø)
ad_rss/src/situation/RssFormulas.cpp 73.98% <ø> (ø)
...ituation/RssStructuredSceneIntersectionChecker.cpp 84.95% <ø> (ø)
... and 163 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b713d7c...5c49d2a. Read the comment docs.

improve var names
f3ce435 
Change-Id: I220121a8bb0219f8d733fc02cdd905c21215747b
fabianoboril
fabianoboril approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@fabianoboril fabianoboril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 207 of 209 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @berndgassmann)

@berndgassmann berndgassmann merged commit ea5b1b8 into master Sep 3, 2021
@berndgassmann berndgassmann deleted the version_number branch September 3, 2021 15:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@fabianoboril fabianoboril fabianoboril approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@berndgassmann @codecov-commenter @fabianoboril