Fix direct route navigation with OIDC by handling base path and stati… #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c assets When users directly navigate to deep links (e.g., /apps/meeting-analyser) with OIDC, assets were failing to load due to incorrect path resolution. Root cause: Base tag was not being created for root-level routes, causing relative asset paths to resolve incorrectly. Changes: 1. server/middleware/setup.js - Add static asset and SPA route bypass for authentication - Prevents auth middleware from blocking HTML pages and assets - Environment-aware: dev-specific paths only in development 2. server/routes/staticRoutes.js - Add file extension check to catch-all route - Return 404 for missing static assets instead of serving index.html - Prevents misrouted asset requests from getting HTML responses 3. client/index.html - Fix base tag detection for root-level routes - When route detected at index 0, set basePath to '/' instead of '' - Always create base tag to ensure proper asset resolution - Still supports subdirectory deployments dynamically Result: Direct navigation to any route now works correctly with proper asset loading, while maintaining subdirectory deployment support. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Contributor
|
🔧 Auto-fix applied: Lint and format issues have been automatically fixed and committed to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…c assets
When users directly navigate to deep links (e.g., /apps/meeting-analyser) with OIDC, assets were failing to load due to incorrect path resolution.
Root cause: Base tag was not being created for root-level routes, causing relative asset paths to resolve incorrectly.
Changes:
server/middleware/setup.js
server/routes/staticRoutes.js
client/index.html
Result: Direct navigation to any route now works correctly with proper asset loading, while maintaining subdirectory deployment support.
🤖 Generated with Claude Code