enhancement: Update shape of the tangle: star trail #924
Conversation
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
79fdb54 to
ec35d92
Compare
There was a problem hiding this comment.
I think the shape could be improved a bit, for example when the blocks per seconds is less, the "spray" should be smaller, and bigger if the bps is bigger. Atm it seems it keeps the same size. Also, the position in the BlockState is the finishing position? I think it would be nice to rename this property to something more specific, since we have initPosition too. Maybe currentPosition if it gets updated or finalPosition or targetPosition if it just contains the last position
|
Also, for some reason, when I change between tabs in my browser, the position of the blocks are different from the ones before |
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
|
@VmMad @begonaalvarezd @msarcev please, review one more time when you will be available Here is screencast to show how it looks now |
please @VmMad lets discuss after christmas if you think there is something that should be improved here
Description of change
fixes #892
Type of change
How the change has been tested
Open visualizer.
Change checklist
Add an
xto the boxes that are relevant to your changes, and delete any items that are not.