Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@VmMad
Copy link
Member

@VmMad VmMad commented Dec 17, 2023

Description of change

  • Disable the posibility for the user to zoom in/out
  • Set a desired automatic zoom based on the viewport
  • Allow to move a bit the camera in the 3 axis, but a limited amount

Fixes #908

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@VmMad VmMad linked an issue Dec 17, 2023 that may be closed by this pull request
@VmMad
Copy link
Member Author

VmMad commented Dec 17, 2023

There is a mesh in the Emitter.tsx file, which you can use to see the zoom that will have the seen more visuallly. Just change the opacity to 1.
Now change in constants the minimum amount of blocks that the tangle will have. With less minimum bps, the tangle should grow in size horizontally.
Everything else can also be changed in constants.
For example the amount of movement that the camera will have, or the safe space (padding) that the tangle will have.

@panteleymonchuk
Copy link
Collaborator

panteleymonchuk commented Dec 18, 2023

I have this behaviour when I open page. Do you have the same behaviour?

Screen.Recording.2023-12-18.at.18.41.30.mov

@panteleymonchuk
Copy link
Collaborator

Now for me issue described above disappear.

Does this initial zoom expected? Emitter is too far from user and zoom doesn't change depends on new blocks comes.
image

If yes - approve from me.

@begonaalvarezd
Copy link
Member

Now for me issue described above disappear.

Does this initial zoom expected? Emitter is too far from user and zoom doesn't change depends on new blocks comes. image

If yes - approve from me.

I would say that indeed this is expected as explained in the call earlier πŸ™πŸΌ, the zoom atm covers the worst case scenario where the BPS are very small, we can polish this in a different PR

@VmMad VmMad self-assigned this Jan 9, 2024
@begonaalvarezd begonaalvarezd merged commit f2af7fe into nova Jan 9, 2024
@begonaalvarezd begonaalvarezd deleted the feat/visualizer/polish-controls-zoom branch January 9, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Polish zoom to fit & user controls

4 participants