-
Notifications
You must be signed in to change notification settings - Fork 827
Revert "Re-enable lds_barrier on RDNA4" #22278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6c07196.
krzysz00
approved these changes
Oct 10, 2025
Contributor
|
Ok, so, to use this PR as the ticket
|
Contributor
|
Poked at packaging up a reproducer and it turns out the O0 is nondeterministically a failure. |
This was referenced Oct 15, 2025
krzysz00
added a commit
to krzysz00/iree
that referenced
this pull request
Oct 15, 2025
This reverts commit cdce159. This re-applies iree-org#21922. This reverts iree-org#22278. The changes in iree-org#22198 appear to have solved the problem.
weidel-p
pushed a commit
to weidel-p/iree
that referenced
this pull request
Oct 21, 2025
Reverts iree-org#21922. This PR re-introduced matmul failures on rdna4. Signed-off-by: Philipp <[email protected]>
weidel-p
pushed a commit
to weidel-p/iree
that referenced
this pull request
Oct 21, 2025
…2326) This reverts commit cdce159. This re-applies iree-org#21922. This reverts iree-org#22278. The changes in iree-org#22198 appear to have solved the problem. ci-extra:test_torch Signed-off-by: Philipp <[email protected]>
newling
added a commit
to newling/iree
that referenced
this pull request
Oct 23, 2025
…ee-org#22326)" This reverts commit f732710.
newling
added a commit
to newling/iree
that referenced
this pull request
Oct 23, 2025
…ee-org#22326)" This reverts commit f732710. Signed-off-by: James Newling <[email protected]>
pstarkcdpr
pushed a commit
to pstarkcdpr/iree
that referenced
this pull request
Nov 28, 2025
Reverts iree-org#21922. This PR re-introduced matmul failures on rdna4.
pstarkcdpr
pushed a commit
to pstarkcdpr/iree
that referenced
this pull request
Nov 28, 2025
…2326) This reverts commit cdce159. This re-applies iree-org#21922. This reverts iree-org#22278. The changes in iree-org#22198 appear to have solved the problem. ci-extra:test_torch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #21922.
This PR re-introduced matmul failures on rdna4.