[GPU] Move convolution check out of unrelated function#22287
Merged
Groverkss merged 3 commits intoiree-org:mainfrom Oct 13, 2025
Merged
[GPU] Move convolution check out of unrelated function#22287Groverkss merged 3 commits intoiree-org:mainfrom
Groverkss merged 3 commits intoiree-org:mainfrom
Conversation
Contributor
Author
|
Depends on #22286 . Please only review the top commit. |
newling
approved these changes
Oct 13, 2025
efric
approved these changes
Oct 13, 2025
weidel-p
pushed a commit
to weidel-p/iree
that referenced
this pull request
Oct 21, 2025
The convolution check is unrelated to reduction iterators. It guards against pooling operations going down the reduction pipeline because we haven't tried sending them down the reduction pipeline before. Signed-off-by: Philipp <[email protected]>
pstarkcdpr
pushed a commit
to pstarkcdpr/iree
that referenced
this pull request
Nov 28, 2025
The convolution check is unrelated to reduction iterators. It guards against pooling operations going down the reduction pipeline because we haven't tried sending them down the reduction pipeline before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The convolution check is unrelated to reduction iterators. It guards against pooling operations going down the reduction pipeline because we haven't tried sending them down the reduction pipeline before.