[StableHLO] Fix reshape canonicalization for dense_resource constants. #22365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8e6a0af to
c4ad1bd
Compare
Member
|
@weidel-p can you remove all the unrelated commits from this PR? |
c4ad1bd to
4643144
Compare
Contributor
Author
|
sorry, the signoff added those by accident. |
kuhar
requested changes
Oct 21, 2025
compiler/plugins/input/StableHLO/Conversion/Preprocessing/Canonicalization.cpp
Outdated
Show resolved
Hide resolved
hanhanW
requested changes
Oct 21, 2025
ff884cb to
8d52a41
Compare
Contributor
Author
|
Thanks for the feedback, please take a look again. |
hanhanW
reviewed
Oct 21, 2025
Contributor
hanhanW
left a comment
There was a problem hiding this comment.
overall looks okay, just few nits.
compiler/plugins/input/StableHLO/Conversion/Preprocessing/test/canonicalization.mlir
Outdated
Show resolved
Hide resolved
| // Test for reshape with dense_resource constants (regression test for crash) | ||
| // CHECK-LABEL: func.func @reshape_dense_resource | ||
| func.func @reshape_dense_resource() -> tensor<8x1x1xf32> { | ||
| %cst = stablehlo.constant dense_resource<torch_tensor_8_torch.float32> : tensor<8xf32> |
Contributor
There was a problem hiding this comment.
You don't need any torch things in StableHLO directory. Can you just do something like dense_resource<__elided__> : tensor<8xf32>, or find a builtin one?
This test will be broken if
Contributor
Author
There was a problem hiding this comment.
I renamed the dense resource with elided.
Contributor
|
Please update PR title. See https://google.github.io/eng-practices/review/developer/cl-descriptions.html for the guidance. |
kuhar
reviewed
Oct 22, 2025
compiler/plugins/input/StableHLO/Conversion/Preprocessing/Canonicalization.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Philipp <[email protected]>
Signed-off-by: Philipp <[email protected]>
…/canonicalization.mlir Co-authored-by: Han-Chung Wang <[email protected]> Signed-off-by: Philipp <[email protected]>
…nicalization.cpp Co-authored-by: Jakub Kuderski <[email protected]> Signed-off-by: Philipp <[email protected]>
Signed-off-by: Philipp <[email protected]>
be292bd to
5070145
Compare
kuhar
reviewed
Oct 22, 2025
compiler/plugins/input/StableHLO/Conversion/Preprocessing/test/canonicalization.mlir
Outdated
Show resolved
Hide resolved
Signed-off-by: Philipp <[email protected]>
kuhar
approved these changes
Oct 22, 2025
Signed-off-by: Philipp <[email protected]>
Contributor
Author
|
sorry, I missed installing the pre-commit tool. Now linting should work. |
pstarkcdpr
pushed a commit
to pstarkcdpr/iree
that referenced
this pull request
Nov 28, 2025
iree-org#22365) Handle DenseResourceElementsAttr in Canonicalization.cpp to deal with 1D dense resources. Fixes: iree-org#22230 --------- Signed-off-by: Philipp <[email protected]> Co-authored-by: Han-Chung Wang <[email protected]> Co-authored-by: Jakub Kuderski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle DenseResourceElementsAttr in Canonicalization.cpp to deal with 1D dense resources.
Fixes: #22230