Adding markAllAnalysesPreserved to verification passes. #22380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verification passes are read-only and don't modify the IR so they should preserve all analyses to avoid unnecessary recomputation in the pass pipeline. We don't use too many analyses today we expect to survive across them but will start to in the future and it's good hygiene. Part of #16168 PR sequence (1/6).
MaheshRavishankar
approved these changes
Oct 23, 2025
hanhanW
approved these changes
Oct 23, 2025
Contributor
hanhanW
left a comment
There was a problem hiding this comment.
I did not know markAllAnalysesPreserved, and it looks good.
bangtianliu
pushed a commit
to bangtianliu/iree
that referenced
this pull request
Oct 30, 2025
Verification passes are read-only and don't modify the IR so they should preserve all analyses to avoid unnecessary recomputation in the pass pipeline. We don't use too many analyses today we expect to survive across them but will start to in the future and it's good hygiene. Part of iree-org#16168 PR sequence (1/6).
bangtianliu
pushed a commit
to bangtianliu/iree
that referenced
this pull request
Nov 19, 2025
Verification passes are read-only and don't modify the IR so they should preserve all analyses to avoid unnecessary recomputation in the pass pipeline. We don't use too many analyses today we expect to survive across them but will start to in the future and it's good hygiene. Part of iree-org#16168 PR sequence (1/6).
pstarkcdpr
pushed a commit
to pstarkcdpr/iree
that referenced
this pull request
Nov 28, 2025
Verification passes are read-only and don't modify the IR so they should preserve all analyses to avoid unnecessary recomputation in the pass pipeline. We don't use too many analyses today we expect to survive across them but will start to in the future and it's good hygiene. Part of iree-org#16168 PR sequence (1/6).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verification passes are read-only and don't modify the IR so they should preserve all analyses to avoid unnecessary recomputation in the pass pipeline. We don't use too many analyses today we expect to survive across them but will start to in the future and it's good hygiene.
Part of #16168 PR sequence (1/6).