-
Notifications
You must be signed in to change notification settings - Fork 824
Adding timeline-aware async execution across module boundaries. #22381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fda1823 to
0712043
Compare
336a10d to
577b0fd
Compare
AWoloszyn
approved these changes
Nov 4, 2025
This introduces the foundational interfaces and attributes needed for timeline-aware scheduling of asynchronous operations that span module boundaries. Of primary interest is the CallAnnotationAttrInterface + AttributeCallGraphPass. These two allow us to synchronize call site information with their callees to allow for local patterns/optimizations to operate without worrying about the globals. This gives us more tightly scoped (and parallelizable) passes in cases where previously they were just at the higher level to avoid hazards. A new IREE::HAL::ABIConventionAttr implements the interface to give us automatic propagation and then later typed retrieval without leaking the input-level iree.abi.* ops as string values any lower. For now it just implements the two modes we support (synchronous and coarse-fences) but in the future can be used to provide per operand/result mapping to fences. The HAL ABI convention attr implements the new IREE::Stream::TimelineAwareOpInterface interface in order to allow for Stream transforms to detect calls to external HAL functions in a generic way. We can also use this for custom ops that behave like Stream ops. No passes are updated to use timeline-aware ops yet as they have... bugs. Future changes will rework/improve the passes and integrate this behavior. Part of #16168 PR sequence (2/6).
577b0fd to
50c7ddc
Compare
bangtianliu
pushed a commit
to bangtianliu/iree
that referenced
this pull request
Nov 19, 2025
…-org#22381) This introduces the foundational interfaces and attributes needed for timeline-aware scheduling of asynchronous operations that span module boundaries. Of primary interest is the `CallAnnotationAttrInterface` + `AttributeCallGraphPass`. These two allow us to synchronize call site information with their callees to allow for local patterns/optimizations to operate without worrying about the globals. This gives us more tightly scoped (and parallelizable) passes in cases where previously they were just at the higher level to avoid hazards. A new `IREE::HAL::ABIConventionAttr` implements the interface to give us automatic propagation and then later typed retrieval without leaking the input-level `iree.abi.*` ops as string values any lower. For now it just implements the two modes we support (synchronous and coarse-fences) but in the future can be used to provide per operand/result mapping to fences. The HAL ABI convention attr is used to service the new `IREE::Stream::TimelineAwareOpInterface` interface in order to allow for Stream transforms to detect calls to external HAL functions in a generic way. We can also use this for custom ops that behave like Stream ops. No passes are updated to use timeline-aware ops yet as they have... bugs. Future changes will rework/improve the passes and integrate this behavior using the interfaces/attrs added here. Part of iree-org#16168 PR sequence (2/6).
pstarkcdpr
pushed a commit
to pstarkcdpr/iree
that referenced
this pull request
Nov 28, 2025
…-org#22381) This introduces the foundational interfaces and attributes needed for timeline-aware scheduling of asynchronous operations that span module boundaries. Of primary interest is the `CallAnnotationAttrInterface` + `AttributeCallGraphPass`. These two allow us to synchronize call site information with their callees to allow for local patterns/optimizations to operate without worrying about the globals. This gives us more tightly scoped (and parallelizable) passes in cases where previously they were just at the higher level to avoid hazards. A new `IREE::HAL::ABIConventionAttr` implements the interface to give us automatic propagation and then later typed retrieval without leaking the input-level `iree.abi.*` ops as string values any lower. For now it just implements the two modes we support (synchronous and coarse-fences) but in the future can be used to provide per operand/result mapping to fences. The HAL ABI convention attr is used to service the new `IREE::Stream::TimelineAwareOpInterface` interface in order to allow for Stream transforms to detect calls to external HAL functions in a generic way. We can also use this for custom ops that behave like Stream ops. No passes are updated to use timeline-aware ops yet as they have... bugs. Future changes will rework/improve the passes and integrate this behavior using the interfaces/attrs added here. Part of iree-org#16168 PR sequence (2/6).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the foundational interfaces and attributes needed for timeline-aware scheduling of asynchronous operations that span module boundaries.
Of primary interest is the
CallAnnotationAttrInterface+AttributeCallGraphPass. These two allow us to synchronize call site information with their callees to allow for local patterns/optimizations to operate without worrying about the globals. This gives us more tightly scoped (and parallelizable) passes in cases where previously they were just at the higher level to avoid hazards. A newIREE::HAL::ABIConventionAttrimplements the interface to give us automatic propagation and then later typed retrieval without leaking the input-leveliree.abi.*ops as string values any lower. For now it just implements the two modes we support (synchronous and coarse-fences) but in the future can be used to provide per operand/result mapping to fences.The HAL ABI convention attr is used to service the new
IREE::Stream::TimelineAwareOpInterfaceinterface in order to allow for Stream transforms to detect calls to external HAL functions in a generic way. We can also use this for custom ops that behave like Stream ops.No passes are updated to use timeline-aware ops yet as they have... bugs. Future changes will rework/improve the passes and integrate this behavior using the interfaces/attrs added here.
Part of #16168 PR sequence (2/6).