Fix iree.build source directory being gitignore'd
#22391
Conversation
| # CMake artifacts | ||
| build/ | ||
| build-*/ | ||
| /build/ | ||
| /build-*/ | ||
| Testing/ | ||
| # Include iree.build package | ||
| !compiler/bindings/python/iree/compiler/build/ |
There was a problem hiding this comment.
I don't have full context on those compiler/build/ and runtime/build/ directories, but if they're just temporary outputs of the packaging process that can be cleaned up after, I don't think they should be git-ignored - that just makes them harder to notice. But I also think almost none of the stuff we have ignored currently should actually be there (people should use a local gitignore config instead).
I'm happy to defer to you guys though, let me know if you'd like those paths added and I can do that.
There was a problem hiding this comment.
They are build directories from building Python packages using https://github.com/iree-org/iree/blob/main/compiler/setup.py and https://github.com/iree-org/iree/blob/main/runtime/setup.py. Standard stuff, hundreds/thousands of generated files. Could be moved to subfolder .gitignore files or the pattern could be changed here, but they need to be excluded for all developers.
c6d2000 to
fbed32a
Compare
The gitignore path is currently wrong (it should be `iree/build`, not `iree/compiler/build`). This switches to selectively ignoring `build` directories instead of selectively un-ignoring, since that seems safer.
The gitignore path is currently wrong (it should be `iree/build`, not `iree/compiler/build`). This switches to selectively ignoring `build` directories instead of selectively un-ignoring, since that seems safer.
The gitignore path is currently wrong (it should be
iree/build, notiree/compiler/build). This switches to selectively ignoringbuilddirectories instead of selectively un-ignoring, since that seems safer.