Update Lit test checks caused by upstream fcf79e5 #22480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d166421 to
c8a9f24
Compare
lialan
commented
Nov 4, 2025
compiler/src/iree/compiler/Codegen/Common/TileDispatchUsingInterface.cpp
Outdated
Show resolved
Hide resolved
185ac83 to
5e54a67
Compare
tileDispatchUsingSCFForOp tiling decisions
1776b60 to
f53376d
Compare
When deciding skip trivial tiling dimensions, the function should consider the cases where workgroup size is larger than tile size. In such cases, we should not simply fold the tiling as it is wrong. Unfortunately `tileDispatchUsingSCFForOp` does not have the way to get the workgroup size, so the fix is to plumb the skip decision into the function. This patch is required for dropping the revert of: llvm/llvm-project@fcf79e5
f53376d to
3907e71
Compare
tileDispatchUsingSCFForOp tiling decisions
hanhanW
approved these changes
Nov 6, 2025
Contributor
hanhanW
left a comment
There was a problem hiding this comment.
Thanks! I just added closes #issue to the PR description.
kuhar
approved these changes
Nov 6, 2025
bangtianliu
pushed a commit
to bangtianliu/iree
that referenced
this pull request
Nov 19, 2025
This patch is required for dropping the revert of: llvm/llvm-project@fcf79e5 Closes iree-org#22171
pstarkcdpr
pushed a commit
to pstarkcdpr/iree
that referenced
this pull request
Nov 28, 2025
This patch is required for dropping the revert of: llvm/llvm-project@fcf79e5 Closes iree-org#22171
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is required for dropping the revert of: llvm/llvm-project@fcf79e5
Closes #22171