[TensorExt] Add barrier ops and roundtrip tests 1/2#22577
Merged
Conversation
Add iree_tensor_ext.barrier.start and iree_tensor_ext.barrier.end operations to control where reshape operations can be propagated during compilation. These are identity operations that pass through their operands unchanged. These barriers prevent undesirable reshape movement, which is useful for controlling reshape propagation at the edges of the program where reshapes exist to convert between function ABI shapes and program dimensionality. Signed-off-by: Ian Wood <[email protected]>
hanhanW
reviewed
Nov 6, 2025
Contributor
hanhanW
left a comment
There was a problem hiding this comment.
let's add a few invalid tests to invalid.mlir: https://github.com/iree-org/iree/tree/main/compiler/src/iree/compiler/Dialect/TensorExt/IR/test
(you have to create the file)
compiler/src/iree/compiler/Dialect/TensorExt/IR/TensorExtOps.td
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Dialect/TensorExt/IR/TensorExtOps.td
Outdated
Show resolved
Hide resolved
Signed-off-by: Ian Wood <[email protected]>
hanhanW
reviewed
Nov 6, 2025
Contributor
hanhanW
left a comment
There was a problem hiding this comment.
Thanks. The PR itself looks good to me. Let me review the other one, just in case if we need to update the semantics.
MaheshRavishankar
approved these changes
Nov 10, 2025
| }]; | ||
|
|
||
| let arguments = (ins | ||
| AnyRankedTensor:$value, |
Collaborator
There was a problem hiding this comment.
To make the IR a bit more succinct did you want to take multiple operands and return multiple results such that every operand maps to the corresponding result? I know the dynamic dims will get complicated. Just a suggestion.
Contributor
Author
There was a problem hiding this comment.
Is it possible to do this with tablegen's "assemblyFormat"? I don't see a way to split value_dims so that each argument has its own set of dynamic dims.
Contributor
There was a problem hiding this comment.
you'll need custom parser and printer in this case I think.
Contributor
Author
There was a problem hiding this comment.
I'm going to keep this as is. I don't think the hassle is worth supporting multiple operands/results.
IanWood1
added a commit
that referenced
this pull request
Nov 12, 2025
This change adds 2 passes to insert and remove tensor barrier ops. - **InsertTensorBarriersPass**: Inserts barrier.start and barrier.end operations at the boundaries of computation regions (tensor/linalg/linalgext ops). This identifies values flowing into and out of compute operations and wraps them with barrier operations. - **RemoveTensorBarriersPass**: Removes barrier operations by replacing their results with their operands, since barriers are identity operations. Depends on #22577 --------- Signed-off-by: Ian Wood <[email protected]>
bangtianliu
pushed a commit
to bangtianliu/iree
that referenced
this pull request
Nov 19, 2025
Add `iree_tensor_ext.barrier.start` and `iree_tensor_ext.barrier.end` operations to control where reshape operations can be propagated during compilation. These barriers prevent undesirable reshape movement, which is useful for controlling reshape propagation at the edges of the program where reshapes exist to convert between function ABI shapes and program dimensionality. --------- Signed-off-by: Ian Wood <[email protected]>
bangtianliu
pushed a commit
to bangtianliu/iree
that referenced
this pull request
Nov 19, 2025
This change adds 2 passes to insert and remove tensor barrier ops. - **InsertTensorBarriersPass**: Inserts barrier.start and barrier.end operations at the boundaries of computation regions (tensor/linalg/linalgext ops). This identifies values flowing into and out of compute operations and wraps them with barrier operations. - **RemoveTensorBarriersPass**: Removes barrier operations by replacing their results with their operands, since barriers are identity operations. Depends on iree-org#22577 --------- Signed-off-by: Ian Wood <[email protected]>
pstarkcdpr
pushed a commit
to pstarkcdpr/iree
that referenced
this pull request
Nov 28, 2025
Add `iree_tensor_ext.barrier.start` and `iree_tensor_ext.barrier.end` operations to control where reshape operations can be propagated during compilation. These barriers prevent undesirable reshape movement, which is useful for controlling reshape propagation at the edges of the program where reshapes exist to convert between function ABI shapes and program dimensionality. --------- Signed-off-by: Ian Wood <[email protected]>
pstarkcdpr
pushed a commit
to pstarkcdpr/iree
that referenced
this pull request
Nov 28, 2025
This change adds 2 passes to insert and remove tensor barrier ops. - **InsertTensorBarriersPass**: Inserts barrier.start and barrier.end operations at the boundaries of computation regions (tensor/linalg/linalgext ops). This identifies values flowing into and out of compute operations and wraps them with barrier operations. - **RemoveTensorBarriersPass**: Removes barrier operations by replacing their results with their operands, since barriers are identity operations. Depends on iree-org#22577 --------- Signed-off-by: Ian Wood <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
iree_tensor_ext.barrier.startandiree_tensor_ext.barrier.endoperations to control where reshape operations can be propagated during compilation. These barriers prevent undesirable reshape movement, which is useful for controlling reshape propagation at the edges of the program where reshapes exist to convert between function ABI shapes and program dimensionality.