[#8591] Re-integrate icommands into main repo (separate histories) #8719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notable changes: - Manpage generation can be toggled with the CMake variable BUILD_DOCS. This defaults to ON if suitable help2man and gzip tools are found. - help2man and gzip are now invoked directly from the buildsystem with no helper shell script. This allows us to leverage CMake's find_program functionality to allow the developer to manually specify the path to help2man and gzip. - New "docs" target. This influences build order to group manpage generation targets together when building "all". - The directory containing libirods_client.so is prepended to LD_LIBRARY_PATH when invoking help2man. This solves/circumvents the transient dependency issue.
Co-authored-by: Jonathon Anderson <[email protected]>
Additionally, bump required CMake to 3.7
This change introduces more exit codes to iphymv based on a family of error codes returned from the server in rsDataObjPhymv. Doing so allows system implementers to take action based on a number of common use cases such as retrying in the face of connection/network errors versus the target replica being written to a node with a full disk.
The itree command can display an easy to digest visualization of a collection in irods. It can print json with -J and display the total size of collections etc.
…s and collections.
- Added release information to itree help text. - Added itree to ihelp.
Also, remove directives for xenial
This commit also fixes UTC display issues with the expiration timestamp for a ticket.
Remove the zone option for iadmin moduser because changing a user's zone is no longer allowed. Removed some of the username sanitizing which was being performed by iadmin before calling the rcGeneralAdmin API. The server should be responsible for checking these inputs.
This commit adds a new function to utility which provides a convenient way to call irods::authentication::authenticate_client using an already-instantiated client environment (as almost all iCommands use). This made replacing the calls relatively painless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8591
Alternate approach: #8725
Early WIP
Commit history of icommands is preserved via a merge commit. This is why there are so many commits in this PR. Additionally, this PR cannot be rebased using standard tooling, so in order to merge, main will likely need to be manually reset to the tip of the PR. I will occasionally manually rebase the PR to keep it up to date with main.
The parents of the merge commit are tip of main for this repo and for irods_client_icommands. They have unrelated histories, so the new commit graph will have two origin points.