Support on Windows for wide character file paths where possible #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File paths on Windows fail to be read in using pyminiaudio if they contain non-ascii characters since Windows uses utf-16 rather than utf-8. The miniaudio library has a few file read functions for handling wide character file paths, so I added them in, where possible, to allow non-ascii file paths to be read in properly on Windows.
There are still plenty of file read functions that do not have a wide character variant in miniaudio nor stb_vorbis that have not been handled though. Not sure if it's something that should be added here or handled by users of the library.