fix test on Big Endian 64bit, due to pointer size mismatch#1014
Merged
ailin-nemui merged 1 commit intoirssi:masterfrom Feb 19, 2019
Merged
fix test on Big Endian 64bit, due to pointer size mismatch#1014ailin-nemui merged 1 commit intoirssi:masterfrom
ailin-nemui merged 1 commit intoirssi:masterfrom
Conversation
Contributor
Author
|
the code was wrong (casting a small size ptr to a larger one) |
Contributor
Author
|
reported via debian build infrastructure / @rhonda |
Contributor
Author
|
@irssi/developers |
Member
|
The fix makes sense, but why are you making a block here? I'd just put the variable declaration at the top of the function with the others. |
Contributor
Author
|
it's just a test.. but you wouldn't want any access to the temporary buf_len, could lead to wrong usage |
ailin-nemui
added a commit
that referenced
this pull request
Apr 7, 2021
fix test on Big Endian 64bit, due to pointer size mismatch (cherry picked from commit 01ce66c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.