New tables DewarRegistry and DewarRegistry_has_Proposal#489
Merged
delageniere merged 1 commit intoispyb:masterfrom Oct 20, 2020
Merged
New tables DewarRegistry and DewarRegistry_has_Proposal#489delageniere merged 1 commit intoispyb:masterfrom
delageniere merged 1 commit intoispyb:masterfrom
Conversation
Collaborator
|
Hi Karl, Thanks ! |
Contributor
Author
|
Thank you, Solange - done! |
Collaborator
|
Thanks ! Could you please commit them to the master repository as .mwb, .pdf and .png ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two tables to hold info about registered dewars, and keep track of which proposals they are associated with.
Note that the DewarRegistry table is different from the Dewar table: The DewarRegistry table is just a look-up table. Users can choose a value from DewarRegistry.facilityCode which we use to populate the Dewar.facilityCode column when they create a shipment.
There were no objections to this at the ISPyB developers meeting today.