fix(jp2): rework the palette box implementation #74
+155
−380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lanzaa
approved these changes
Dec 17, 2025
| reader.read_exact(&mut value_bytes)?; | ||
| u16::from_be_bytes(value_bytes) as u32 | ||
| } | ||
| _ => unimplemented!( |
Collaborator
There was a problem hiding this comment.
Nice to have: 32-bit support might be worth implementing.
Collaborator
Author
There was a problem hiding this comment.
While it would be nice, I don't think paletted colour with > 16 bits per component is that likely.
I allowed for up to 32 bits in the API, and 32 bits isn't that hard to do. The 24 bit case is somewhat messier though.
Owner
There was a problem hiding this comment.
Agreed, it's unlikely and we can always add it later.
This matches the results of the file9.jp2 sample. Resolves iszak#46
07fb51d to
9a14a1b
Compare
iszak
reviewed
Dec 23, 2025
| j += 1; | ||
| for _ in 0..num_entries { | ||
| let mut entry_components = Vec::<u32>::with_capacity(num_palette_columns as usize); | ||
| for i in 0..num_palette_columns as usize { |
Owner
There was a problem hiding this comment.
Nit, you could use entry_components.capacity()
Owner
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the results of the file9.jp2 sample.
Resolves #46