support Input method and C-v paste when editing text #182
Conversation
|
This looks interesting, but I would like to test it out before merging. Unfortunately I won't have access to my Linux machine before the end of the year. It it goes well I'll merge it before Christmas. Sorry for the wait. |
|
@jtheoof Thanks for your great work on this, do you have any plan merge this patch to a new release? |
bdead6e to
c822d6c
Compare
|
this is harder to review, since you included changes from #183 can you dissociate both MRs and code ? |
Fixed. It should have been accidentally pushed to this branch. |
jtheoof
left a comment
There was a problem hiding this comment.
Looking good tried it out. works well, just a question around memory of the im_context object.
|
|
||
| GtkWindow *window = | ||
| GTK_WINDOW(gtk_builder_get_object(builder, "paint-window")); | ||
| GtkIMContext *im_context = gtk_im_multicontext_new(); |
There was a problem hiding this comment.
I'm not sure how this gtk object works, but aren't you supposed to g_free(im_context) to release the memory upon closing the app (in application_finish function)
this should close #154