Merge paths if they already are added to the paths map in utoipa-axum #1171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juhaku
requested changes
Oct 28, 2024
Owner
juhaku
left a comment
There was a problem hiding this comment.
Nice, thanks for fixing, 👍 Could you add a CHANGELOG entry top of the file for this change.
## Unreleased
### Changed
* This is the PR title (link)
Contributor
Author
|
@juhaku Thanks for having a look. I've updated the CHANGELOG and removed the |
juhaku
reviewed
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old version of the diff would overwrite old routes to the paths map even if they had a different method, so this change merges them instead